Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for build config into oc set env #7625

Merged
merged 1 commit into from Mar 2, 2016
Merged

Add support for build config into oc set env #7625

merged 1 commit into from Mar 2, 2016

Conversation

mfojtik
Copy link
Member

@mfojtik mfojtik commented Feb 25, 2016

Allow to run:

[root@localhost origin]# oc set env bc/ruby-hello-world FOO=bar
buildconfig "ruby-hello-world" updated
[root@localhost origin]# oc set env bc/ruby-hello-world --list
# buildconfigs ruby-hello-world
FOO=bar
[root@localhost origin]# oc set env dc/ruby-hello-world bc/ruby-hello-world FOO=foo
deploymentconfig "ruby-hello-world" updated
buildconfig "ruby-hello-world" updated

@mfojtik mfojtik mentioned this pull request Feb 25, 2016
Closed
@mfojtik
Copy link
Member Author

mfojtik commented Feb 25, 2016

[test]

@mfojtik mfojtik force-pushed the oc-set-env-bc-v2 branch 2 times, most recently from 78e6c6c to d0bbbe4 Compare February 25, 2016 17:59
@mfojtik mfojtik changed the title WIP: Add support for build config into oc set env Add support for build config into oc set env Feb 25, 2016
@mfojtik
Copy link
Member Author

mfojtik commented Feb 25, 2016

@smarterclayton @Kargakis PTAL

0xmichalis
0xmichalis reviewed Feb 25, 2016
View reviewed changes
pkg/cmd/cli/cmd/set/env.go
@@ -20,11 +20,13 @@ import (

const (
envLong = `
Update environment variables on a pod template
Update environment variables on a pod template and build config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or a build config

@mfojtik
Copy link
Member Author

mfojtik commented Feb 25, 2016

[test]

@mfojtik
Copy link
Member Author

mfojtik commented Feb 28, 2016

[test]

@smarterclayton bump.

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to e3b9f12

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/1707/)

@0xmichalis
Copy link
Contributor

LGTM

@mfojtik
Copy link
Member Author

mfojtik commented Mar 2, 2016

@smarterclayton merge?

@smarterclayton
Copy link
Contributor

Lgtm [merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5173/) (Image: devenv-rhel7_3591)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to e3b9f12

openshift-bot pushed a commit that referenced this pull request Mar 2, 2016
Merge pull request #7625 from mfojtik/oc-set-env-bc-v2
978ac81 
Merged by openshift-bot
@openshift-bot openshift-bot merged commit 978ac81 into openshift:master Mar 2, 2016
@mfojtik mfojtik deleted the oc-set-env-bc-v2 branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mfojtik @openshift-bot @0xmichalis @smarterclayton