Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed binary etcd store from test-cmd artfacts #8211

Merged
merged 1 commit into from
Mar 23, 2016

Conversation

stevekuznetsov
Copy link
Contributor

Until my refactor goes in, test-cmd does cleanup it's own special way, so we need to duplicate #8169 here.

@deads2k @danmcp PTAL

@deads2k
Copy link
Contributor

deads2k commented Mar 23, 2016

Am I just missing the etcd dump here?

@stevekuznetsov
Copy link
Contributor Author

@deads2k I don't quite understand the question

@deads2k
Copy link
Contributor

deads2k commented Mar 23, 2016

@deads2k I don't quite understand the question

Where is the bit of in test-cmd bash that is dumping the content of etcd as a json file for me to debug with? Looks like you're removing information without replacing it.

@stevekuznetsov
Copy link
Contributor Author

Ah, I thought we had it already. Seems as though you're right - added it now.

@deads2k
Copy link
Contributor

deads2k commented Mar 23, 2016

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2469/) (Image: devenv-rhel7_3816)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 32c5f69

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 32c5f69

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/2469/)

@openshift-bot openshift-bot merged commit 7728ca3 into openshift:master Mar 23, 2016
@stevekuznetsov stevekuznetsov deleted the skuznets/etcd-last branch June 15, 2016 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants