Default role reconciliation to additive-only #8603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
[test] |
|
Failed in pullthrough due to unauthorized - post 1.2 I'll turn debugging up to 5 on the importer package so we get output. I think the run started after the Open() fix merged, so... |
|
Prune failed [test] |
|
Evaluated for origin test up to f0fd44a |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3202/) |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3202/) (Image: devenv-rhel7_4047) |
|
Evaluated for origin merge up to f0fd44a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1328822 by changing the CLI default behavior to leave existing permissions alone.
oadm policy reconcile-cluster-roles --additive-only=falsecan still be used to tighten permissions to the current defaults.