Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yaml.js to latest, official version #8708

Merged
merged 1 commit into from
May 2, 2016

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented May 2, 2016

We were unknowingly picking up a yaml.js fork (klederson/yaml.js) that registered bower support rather than the official repository (jeremyfa/yaml.js). The fork is a very old version that doesn't parse some valid YAML.

Use the latest from jeremyfa/yaml.js.

@jwforres @jhadvig

@spadgett spadgett added this to the 1.3.0 milestone May 2, 2016
@jwforres
Copy link
Member

jwforres commented May 2, 2016

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented May 2, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5780/) (Image: devenv-rhel7_4076)

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 79f48a6

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 79f48a6

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/3523/)

@openshift-bot openshift-bot merged commit c4f3454 into openshift:master May 2, 2016
@spadgett spadgett deleted the update-yamljs branch May 12, 2016 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants