Project should not fetch client immediately #8782
Merged
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ClientConfig *restclient.Config | ||
| Client func() (*client.Client, error) |
|
name nit, LGTM otherwise |
oc project can be used to switch config contexts, but loads its client in the Complete() method which does API negotiation. Since a user may not be logged in or the server they are talking to may be down, changing projects then doesn't work. Use a lazy client loader just for project until we can sort out lazy api negotiation and/or something better on client.
smarterclayton
force-pushed
the
project_change
branch
from
00e5d19
to
205f9d7
Compare
|
renamed [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/5846/) (Image: devenv-rhel7_4135) |
|
Evaluated for origin merge up to 205f9d7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oc project can be used to switch config contexts, but loads its client
in the Complete() method which does API negotiation. Since a user may
not be logged in or the server they are talking to may be down, changing
projects then doesn't work.
Use a lazy client loader just for project until we can sort out lazy api
negotiation and/or something better on client.
@liggitt because I hate API negotiation almost as much as you.