Change release builder process to lock versions #9278

smarterclayton · 2016-06-10T18:21:32Z

[test]

smarterclayton · 2016-06-13T19:35:54Z

[test]

smarterclayton · 2016-06-13T21:17:25Z

@runcom I'm consistently seeing:

Digest: sha256:9d6946f7b2e8a1ad29f75595c295e5f3c997920e6f8ff71adc482da00c59e8e9
Status: Downloaded newer image for docker.io/openshift/origin-release:golang-1.6
An error occurred trying to connect: Put http:///var/run/docker.sock/v1.22/containers/ee8ad6a7ee99c11a601ace1238bdfb15904ab9e7af6c12235924588c6aad2675/archive?noOverwriteDirNonDir=true&path=%2Fgo%2Fsrc%2Fgithub.com%2Fopenshift%2Forigin: write unix /var/run/docker.sock: broken pipe
!!! Error in hack/build-release.sh:49
    'docker cp - $container:$(docker inspect -f '{{ index . "Config" "WorkingDir" }}' $container)' exited with status 141 1
Call stack:
    1: hack/build-release.sh:49 main(...)
Exiting with status 1

with these changes. Are you aware of anything with cat and docker cp on RHEL that would cause this?

Client:
 Version:         1.10.3
 API version:     1.22
 Package version: docker-common-1.10.3-25.el7.x86_64
 Go version:      go1.4.2
 Git commit:      86bbf84/1.10.3
 Built:           
 OS/Arch:         linux/amd64

Server:
 Version:         1.10.3
 API version:     1.22
 Package version: docker-common-1.10.3-25.el7.x86_64
 Go version:      go1.4.2
 Git commit:      86bbf84/1.10.3
 Built:           
 OS/Arch:         linux/amd64

runcom · 2016-06-13T21:21:24Z

@smarterclayton that sounds like a panic - do you have daemon logs?

smarterclayton · 2016-06-13T21:48:33Z

Added something to dump the docker journal - next run should show it here.

smarterclayton · 2016-06-13T22:02:18Z

[test]

smarterclayton · 2016-06-13T22:56:22Z

Yes, looks like a panic from https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_integration/1875/console

runcom · 2016-06-13T23:15:29Z

@smarterclayton is that all of the output from the panic? 😕

smarterclayton · 2016-06-13T23:18:46Z

That's whatever the default window is from the journal - how much do you
need?

On Jun 13, 2016, at 7:15 PM, Antonio Murdaca notifications@github.com
wrote:

@smarterclayton https://github.com/smarterclayton is that all of the
output from the panic? 😕

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9278 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABG_pxgcmekhSA3aT-2CH3C9_c-w6b5Oks5qLeSUgaJpZM4IzMty
.

runcom · 2016-06-13T23:20:57Z

@smarterclayton I'd say the full docker journal

smarterclayton · 2016-06-14T01:01:23Z

Now with all docker logs https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_integration/1879/console

runcom · 2016-06-14T01:09:00Z

This is really weird, the stack trace does not seem tied to docker but to golang (if I'm reading it correctly). Could you guys try and update the docker version from 25 to at least 40? (build number). I'll see if there are fixer to docker cp upstream which didn't make 1.10 and may cause this

smarterclayton · 2016-06-14T01:31:30Z

@stevekuznetsov let's chat about this tomorrow.

smarterclayton · 2016-06-14T15:45:37Z

[test] now that we're on 40

stevekuznetsov · 2016-06-14T16:56:49Z

hack/build-release.sh

-docker cp $(cat ${context}/cid):/go/src/github.com/openshift/origin/_output/local/releases "${OS_OUTPUT}"
+docker create -e "OS_ONLY_BUILD_PLATFORMS=${OS_ONLY_BUILD_PLATFORMS-}" --cidfile="${context}/cid" "${release_image}" > /dev/null
+container=$(cat ${context}/cid)
+cat "${context}/archive.tar.gz" | docker cp - $container:$(docker inspect -f '{{ index . "Config" "WorkingDir" }}' $container)


"${container}:$( docker inspect ... )"

smarterclayton · 2016-06-14T22:12:47Z

Depends on #9335 to get at make in the container.

stevekuznetsov · 2016-06-15T17:54:35Z

hack/common.sh

+# and OS_RELEASE_DOCKER_ARGS can be used to customize the container. The docker socket
+# is mounted by default and the output of the command is the container id.
+os::build::environment::create() {


function namespaced::function::name() { ^^^^^^^^

stevekuznetsov · 2016-06-15T18:04:50Z

@smarterclayton looks nice

doesn't play nice when you don't have OSE image locally:

$ OS_BUILD_ENV_IMAGE=ose/release:3.3 hack/env make
Unable to find image 'ose/release:3.3' locally
Trying to pull repository docker.io/ose/release ... not found
Error: image ose/release:3.3 not found
Unable to read inspect data: json: cannot unmarshal array into Go value of type types.ContainerJSON
Container name cannot be empty
invalid value "origin-build-1d7a7a72cde41fe2e0cd17b8ce6d063aa1bf2cc3:" for flag -v:  is not an absolute path
See 'docker create --help'.
!!! Error in hack/../hack/common.sh:960
    'container="$( os::build::environment::create "$@" )"' exited with status 2
Call stack:
    1: hack/../hack/common.sh:960 os::build::environment::run(...)
    2: hack/env:21 main(...)
Exiting with status 1

smarterclayton · 2016-06-15T18:11:40Z

Hrm - yeah, that is ugly, i think that's the local screening the exit
code. Let me try.

On Wed, Jun 15, 2016 at 2:04 PM, Steve Kuznetsov notifications@github.com
wrote:

@smarterclayton https://github.com/smarterclayton looks nice

doesn't play nice when you don't have OSE image locally:

$ OS_BUILD_ENV_IMAGE=ose/release:3.3 hack/env make
Unable to find image 'ose/release:3.3' locally
Trying to pull repository docker.io/ose/release ... not found
Error: image ose/release:3.3 not found
Unable to read inspect data: json: cannot unmarshal array into Go value of type types.ContainerJSON
Container name cannot be empty
invalid value "origin-build-1d7a7a72cde41fe2e0cd17b8ce6d063aa1bf2cc3:" for flag -v: is not an absolute path
See 'docker create --help'.
!!! Error in hack/../hack/common.sh:960
'container="$( os::build::environment::create "$@" )"' exited with status 2
Call stack:
1: hack/../hack/common.sh:960 os::build::environment::run(...)
2: hack/env:21 main(...)
Exiting with status 1

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9278 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABG_p_-Guii60rIe4wvM2bes7Yeo5LWQks5qMD7EgaJpZM4IzMty
.

smarterclayton · 2016-06-15T18:29:53Z

Updated

On Wed, Jun 15, 2016 at 2:11 PM, Clayton Coleman ccoleman@redhat.com
wrote:

Hrm - yeah, that is ugly, i think that's the local screening the exit
code. Let me try.

On Wed, Jun 15, 2016 at 2:04 PM, Steve Kuznetsov <notifications@github.com

wrote:

@smarterclayton https://github.com/smarterclayton looks nice

doesn't play nice when you don't have OSE image locally:

$ OS_BUILD_ENV_IMAGE=ose/release:3.3 hack/env make
Unable to find image 'ose/release:3.3' locally
Trying to pull repository docker.io/ose/release ... not found
Error: image ose/release:3.3 not found
Unable to read inspect data: json: cannot unmarshal array into Go value of type types.ContainerJSON
Container name cannot be empty
invalid value "origin-build-1d7a7a72cde41fe2e0cd17b8ce6d063aa1bf2cc3:" for flag -v: is not an absolute path
See 'docker create --help'.
!!! Error in hack/../hack/common.sh:960
'container="$( os::build::environment::create "$@" )"' exited with status 2
Call stack:
1: hack/../hack/common.sh:960 os::build::environment::run(...)
2: hack/env:21 main(...)
Exiting with status 1

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9278 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABG_p_-Guii60rIe4wvM2bes7Yeo5LWQks5qMD7EgaJpZM4IzMty
.

stevekuznetsov · 2016-06-15T18:54:52Z

hack/common.sh

+# is mounted by default and the output of the command is the container id.
+function os::build::environment::create() {
+  set -o errexit


this is surprising

Without that it would fail to warn me.

On Wed, Jun 15, 2016 at 2:54 PM, Steve Kuznetsov notifications@github.com
wrote:

In hack/common.sh
#9278 (comment):

\ No newline at end of file
+readonly -f os::build::find-binary
+
+# os::build::environment::create creates a docker container with the default variables.
+# arguments are passed directly to the container, OS_BUILD_ENV_GOLANG, OS_BUILD_ENV_IMAGE,
+# and OS_RELEASE_DOCKER_ARGS can be used to customize the container. The docker socket
+# is mounted by default and the output of the command is the container id.
+function os::build::environment::create() {

set -o errexit

this is surprising

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/openshift/origin/pull/9278/files/8437cd96443c7aee0b866981c9a57910926e0646#r67223630,
or mute the thread
https://github.com/notifications/unsubscribe/ABG_p8tLhbDD6m6lS-eqTEZPjCl39kn_ks5qMEp9gaJpZM4IzMty
.

openshift-bot · 2016-06-15T19:55:53Z

Evaluated for origin test up to 717e5e2

Reorganize to make more friendly for docker build behavior. Note that after this change openshift/origin-release:latest can no longer be used with hack/build-release.sh. Add a new hack/env stub that makes it easy to run containerized if necessary.

openshift-bot · 2016-06-15T21:04:03Z

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4935/)

smarterclayton · 2016-06-15T21:18:52Z

Stack trace installed. set -o errtrace makes no difference when i tested.

On Wed, Jun 15, 2016 at 5:04 PM, OpenShift Bot notifications@github.com
wrote:

continuous-integration/openshift-jenkins/test SUCCESS (
https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4935/)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#9278 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABG_p3d3bmG1fRCVddC3nR-MuaKAYD-uks5qMGjFgaJpZM4IzMty
.

smarterclayton · 2016-06-18T19:50:31Z

[merge] so I can experiment with other parts

openshift-bot · 2016-06-18T19:55:11Z

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/5085/) (Image: devenv-rhel7_4407)

openshift-bot · 2016-06-18T19:55:11Z

Evaluated for origin merge up to 717e5e2

smarterclayton force-pushed the improve_release branch 2 times, most recently from afad484 to 69a50c6 Compare June 13, 2016 17:53

smarterclayton force-pushed the improve_release branch 2 times, most recently from 8c0a676 to 35211f1 Compare June 13, 2016 20:47

smarterclayton changed the title ~~WIP - Change release builder process to lock versions~~ Change release builder process to lock versions Jun 13, 2016

smarterclayton force-pushed the improve_release branch from ed46ebe to 84ca4c8 Compare June 14, 2016 00:37

smarterclayton force-pushed the improve_release branch from 84ca4c8 to 35211f1 Compare June 14, 2016 16:37

stevekuznetsov reviewed Jun 14, 2016
View reviewed changes

smarterclayton force-pushed the improve_release branch 2 times, most recently from 4ac87bb to 258c105 Compare June 14, 2016 22:11

smarterclayton force-pushed the improve_release branch 4 times, most recently from 38917d1 to a90d9e7 Compare June 14, 2016 22:42

stevekuznetsov reviewed Jun 15, 2016
View reviewed changes

openshift-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 15, 2016

smarterclayton force-pushed the improve_release branch from 1d7a7a7 to 8437cd9 Compare June 15, 2016 18:29

stevekuznetsov reviewed Jun 15, 2016
View reviewed changes

smarterclayton force-pushed the improve_release branch from 8437cd9 to 717e5e2 Compare June 15, 2016 19:55

openshift-bot merged commit 435c318 into openshift:master Jun 18, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change release builder process to lock versions #9278

Change release builder process to lock versions #9278

smarterclayton commented Jun 10, 2016

smarterclayton commented Jun 13, 2016

smarterclayton commented Jun 13, 2016 •

edited

runcom commented Jun 13, 2016

smarterclayton commented Jun 13, 2016

smarterclayton commented Jun 13, 2016

smarterclayton commented Jun 13, 2016 via email

runcom commented Jun 13, 2016

smarterclayton commented Jun 13, 2016

runcom commented Jun 13, 2016

smarterclayton commented Jun 14, 2016

runcom commented Jun 14, 2016

smarterclayton commented Jun 14, 2016

smarterclayton commented Jun 14, 2016 •

edited

stevekuznetsov Jun 14, 2016 •

edited

smarterclayton commented Jun 14, 2016

stevekuznetsov Jun 15, 2016 •

edited

stevekuznetsov commented Jun 15, 2016

smarterclayton commented Jun 15, 2016

smarterclayton commented Jun 15, 2016

stevekuznetsov Jun 15, 2016

smarterclayton Jun 15, 2016

openshift-bot commented Jun 15, 2016

openshift-bot commented Jun 15, 2016

smarterclayton commented Jun 15, 2016

smarterclayton commented Jun 18, 2016

openshift-bot commented Jun 18, 2016 •

edited

openshift-bot commented Jun 18, 2016

Change release builder process to lock versions #9278

Change release builder process to lock versions #9278

Conversation

smarterclayton commented Jun 10, 2016

smarterclayton commented Jun 13, 2016

smarterclayton commented Jun 13, 2016 • edited

runcom commented Jun 13, 2016

smarterclayton commented Jun 13, 2016

smarterclayton commented Jun 13, 2016

smarterclayton commented Jun 13, 2016 via email

runcom commented Jun 13, 2016

smarterclayton commented Jun 13, 2016

runcom commented Jun 13, 2016

smarterclayton commented Jun 14, 2016

runcom commented Jun 14, 2016

smarterclayton commented Jun 14, 2016

smarterclayton commented Jun 14, 2016 • edited

stevekuznetsov Jun 14, 2016 • edited

Choose a reason for hiding this comment

smarterclayton commented Jun 14, 2016

stevekuznetsov Jun 15, 2016 • edited

Choose a reason for hiding this comment

stevekuznetsov commented Jun 15, 2016

smarterclayton commented Jun 15, 2016

smarterclayton commented Jun 15, 2016

stevekuznetsov Jun 15, 2016

Choose a reason for hiding this comment

smarterclayton Jun 15, 2016

Choose a reason for hiding this comment

openshift-bot commented Jun 15, 2016

openshift-bot commented Jun 15, 2016

smarterclayton commented Jun 15, 2016

smarterclayton commented Jun 18, 2016

openshift-bot commented Jun 18, 2016 • edited

openshift-bot commented Jun 18, 2016

smarterclayton commented Jun 13, 2016 •

edited

smarterclayton commented Jun 14, 2016 •

edited

stevekuznetsov Jun 14, 2016 •

edited

stevekuznetsov Jun 15, 2016 •

edited

openshift-bot commented Jun 18, 2016 •

edited