Update pipeline template annotations #9328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs hack/gen-bootstrap run |
spadgett
force-pushed
the
fix-jenkins-service-annotations
branch
from
761aaf8
to
ea107f8
Compare
|
thanks @bparees another look? |
|
lgtm [merge] |
* Move Jenkins pipeline template service annotations to correct resource * Add pipeline.alpha.openshift.io/uses to the pipeline BuildConfig
spadgett
force-pushed
the
fix-jenkins-service-annotations
branch
from
ea107f8
to
f09261f
Compare
|
@bparees Spoke to @smarterclayton. We want to use @smarterclayton Look right? |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4854/) (Image: devenv-rhel7_4373) |
|
Evaluated for origin merge up to f09261f |
|
[Test]ing while waiting on the merge queue |
| @@ -19,6 +19,9 @@ | |||
| "creationTimestamp": null, | |||
| "labels": { | |||
| "name": "sample-pipeline" | |||
| }, | |||
| "annotations": { | |||
| "pipeline.alpha.openshift.io/uses": "[{\"name\": \"frontend\", \"namespace\": \"\", \"kind\": \"DeploymentConfig\"}]" | |||
There was a problem hiding this comment.
is this supplanting this pr:
#9275
?
|
Evaluated for origin test up to f09261f |
spadgett
changed the title
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4854/) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bparees PTAL
@jwforres CC