Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed glog V(1) and V(2) to V(0) #9332

Merged
merged 1 commit into from Jun 15, 2016
Merged

Changed glog V(1) and V(2) to V(0) #9332

merged 1 commit into from Jun 15, 2016

Conversation

jupierce
Copy link
Contributor

fixes #9247

Changed glog V(1) and V(2) to log at V(0) to ensure necessary log output is captured by extended build tests.

@jupierce
Copy link
Contributor Author

Thanks @csrwng . Made the changes, squashed, and pushed again.

@csrwng
Copy link
Contributor

csrwng commented Jun 15, 2016

lgtm
[merge]

@csrwng
Copy link
Contributor

csrwng commented Jun 15, 2016

Error pulling ruby builder in e2e (not sure if it's network flake):

Trying to pull repository docker.io/centos/ruby-22-centos7 ... 
...
failed to register layer: ApplyLayer open /dev/mapper/docker-202:2-603008-9f0986b51e88b338bfe1c95c093660e359185e83bc6138c39d1f932b780db346: no such file or directory stdout: {"layerSize":0}

[merge]

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 15, 2016

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/4928/) (Image: devenv-rhel7_4382)

@csrwng
Copy link
Contributor

csrwng commented Jun 15, 2016

Seems like another network flake:

--- FAIL: TestTriggers_imageChange_nonAutomatic (125.78s)
    deploy_trigger_test.go:246: Waiting for image stream mapping to be reflected in the image stream status...

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 5613fa6

@openshift-bot openshift-bot merged commit 60b951e into openshift:master Jun 15, 2016
@smarterclayton
Copy link
Contributor

Guys, this is way too much output that users don't need. We need to walk some of this back - end users don't (for instance) care about any of the following:

The value of ALLOWED_UIDS is [1-]
The value of DROP_CAPS is [KILL,MKNOD,SETGID,SETUID,SYS_CHROOT]
Image "centos/php-56-centos7@sha256:51c3e2b08bd9fadefccd6ec42288680d6d7f861bdbfbd2d8d24960621e4e27f5" not available locally, pulling ...
Creating a new S2I builder with build config: "Builder Name:\t\t\tApache 2.4 with PHP 5.6\nBuilder Image:\t\t\tcentos/php-56-centos7@sha256:51c3e2b08bd9fadefccd6ec42288680d6d7f861bdbfbd2d8d24960621e4e27f5\nBuilder Image Version:\t\t186a9c8caca0ef9eec4125247979876bf2c937b4\nBuilder Base Version:\t\taac5e76\nSource:\t\t\t\tfile:///tmp/s2i-build607401544/upload/src\nOutput Image Tag:\t\texample/cakephp-mysql-example-1:0d661744\nEnvironment:\t\t\tOPENSHIFT_BUILD_NAME=cakephp-mysql-example-1,OPENSHIFT_BUILD_NAMESPACE=example,OPENSHIFT_BUILD_SOURCE=https://github.com/openshift/cakephp-ex.git\nIncremental Build:\t\tdisabled\nRemove Old Build:\t\tdisabled\nBuilder Pull Policy:\t\tif-not-present\nPrevious Image Pull Policy:\talways\nQuiet:\t\t\t\tdisabled\nLayered Build:\t\t\tdisabled\nWorkdir:\t\t\t/tmp/s2i-build607401544\nDocker NetworkMode:\t\tcontainer:4be62ce657ac063cd020206e83adfe4253d2f8aa12077168e466554d8befd46c\nDocker Endpoint:\t\tunix:///var/run/docker.sock\n"
Downloading "https://github.com/openshift/cakephp-ex.git" ...
Cloning source from https://github.com/openshift/cakephp-ex.git
I0618 21:07:53.282588       1 install.go:123] DEPRECATED: Use .s2i/bin instead of .sti/bin
I0618 21:07:53.282883       1 install.go:251] Using "assemble" installed from "<source-dir>/.sti/bin/assemble"
I0618 21:07:53.282953       1 install.go:251] Using "run" installed from "image:///usr/libexec/s2i/run"
I0618 21:07:53.282973       1 install.go:251] Using "save-artifacts" installed from "image:///usr/libexec/s2i/save-artifacts"
Using provided push secret for pushing 172.30.209.18:5000/example/cakephp-mysql-example:latest image

We only need 1 of "Downloading" or "Cloning", and the "pull" message is way too long. Please either revert or fix this so that normal users only get the absolute most critical information they need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants