Fix pullthrough serve blob

[miminar]

Don't attempt to copy any data on a HEAD.

Closes #8613

[miminar]

Tested manually with tcpdump.

[miminar]

Looks like flake #9775

Running test/end-to-end/core.sh:29: executing 'oc get -n test pods' expecting any result and text 'frontend.+Running'; re-trying every 0.2s until completion or 120.000s...
FAILURE after 119.691s: test/end-to-end/core.sh:29: executing 'oc get -n test pods' expecting any result and text 'frontend.+Running'; re-trying every 0.2s until completion or 120.000s: the command timed out

[test]

[miminar]

@legionus PTAL

[legionus]

@miminar Can you add integration test for that ?

[miminar]

@legionus would a unit test do?

[legionus]

I think you can use any test that checks for this.

[mfojtik]

@miminar do we need to backport this?

[miminar]

@mfojtik it would be nice. Once merged, I'll do the backport. I haven't yet got the chance to finish the tests though.

[miminar]

@legionus, @soltysh: unit tests added.

[miminar]

@smarterclayton fyi

[legionus]

LGTM

@mfojtik We need to backport it.

[soltysh]

LGTM

[liggitt]

let's get the blob ACL PR in first

[miminar]

Yeah, it will conflict for sure.

[miminar]

Flake #10263. https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_networking/3930/

re-[test]

[miminar]

I just don't know, how to defeat "The Origin test job could not be run again for this pull request." message without altering commits. In the end, I gave up and re-signed the last commit to move forward.

[stevekuznetsov]

@miminar as the bot requests, you need to have the failed Jenkins job link. The sentence telling you that this link is necessary also has a hyperlink to the failed job it is searching for. This job is the job that was triggered by the bot, so it will be test_pr_origin, not one of the sub-jobs like test_pull_requests_origin_networking. This is a required feature as you could have both failed merge and test jobs in the PR at the same time. The bot needs to know for which failed job you are declaring flakes to have been found.

[miminar]

@stevekuznetsov thanks! That's 1:0 for the bot. I'm sure I'll win next time.

[miminar]

Flake #10274. Job https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7632/
And flake #9490. re-[test]

[stevekuznetsov]

@miminar I'm actually impressed, with your newest comment you found two other bugs in the bot ... I didn't even realize the first way you linked to an issue was a valid thing ... give me a moment.

[miminar]

I'm always glad to help. 😄

[openshift-bot]

Evaluated for origin test up to 1245726

[openshift-bot]

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7902/)

[miminar]

@mfojtik can you please merge?

[mfojtik]

[merge]

[openshift-bot]

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/7919/) (Image: devenv-rhel7_4829)

[openshift-bot]

Evaluated for origin merge up to 1245726