Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow on to the AuthorizationAttributes -> Action PR to fix authorization conversions #9838

Closed
wants to merge 3 commits into from
Closed

Follow on to the AuthorizationAttributes -> Action PR to fix authorization conversions #9838

wants to merge 3 commits into from

Commits on Jul 19, 2016

  1. UPSTREAM: 28931: genconversion=false should skip fields during conver… 

    …sion generation

Currently it only skips if the fields don't match, but that leaves no
way for callers to say "no really, ignore this field".
    @smarterclayton
    smarterclayton committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    1fa99a3 View commit details
    Browse the repository at this point in the history

  2. Rename AuthorizationAttributes -> Action 

    Allows conversions to be automatically generated, and the name is not
externally visible. Subsequent commits will update the conversions.
    @smarterclayton
    smarterclayton committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    9c482b5 View commit details
    Browse the repository at this point in the history

  3. Make authorization conversions efficient 

    Prepare for protobuf by adding aliases for nullable fields.
    @smarterclayton
    smarterclayton committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    d25c78f View commit details
    Browse the repository at this point in the history