Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-34026: [release-4.16] gitmodules: track rhcos-4.16 branch #1510

Merged
merged 3 commits into from
May 28, 2024
Merged

OCPBUGS-34026: [release-4.16] gitmodules: track rhcos-4.16 branch #1510

merged 3 commits into from
May 28, 2024

Conversation

mike-nguyen
Copy link
Member

Start tracking the rhcos-4.16 branch of fedora-coreos-config as a part of branching 4.16.

@mike-nguyen
gitmodules: track rhcos-4.16 branch
76cf07f 
Start tracking the rhcos-4.16 branch of fedora-coreos-config as a
part of branching 4.16.
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@mike-nguyen
Copy link
Member Author

/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels May 21, 2024
@mike-nguyen
Copy link
Member Author

/retitle OCPBUGS-34026: [release-4.16] gitmodules: track rhcos-4.16 branch

@openshift-ci openshift-ci bot changed the title [release-4.16] gitmodules: track rhcos-4.16 branch OCPBUGS-34026: [release-4.16] gitmodules: track rhcos-4.16 branch May 21, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 21, 2024
@openshift-ci-robot
Copy link

@mike-nguyen: This pull request references Jira Issue OCPBUGS-34026, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-34026 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Start tracking the rhcos-4.16 branch of fedora-coreos-config as a part of branching 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mike-nguyen
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@mike-nguyen: This pull request references Jira Issue OCPBUGS-34026, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected Jira Issue OCPBUGS-34026 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mike-nguyen
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 21, 2024
@openshift-ci-robot
Copy link

@mike-nguyen: This pull request references Jira Issue OCPBUGS-34026, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-34028 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-34028 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @aaradhak

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from aaradhak May 21, 2024 12:54
@jlebon
Copy link
Member

jlebon commented May 21, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8e6ac83 and 2 for PR HEAD 76cf07f in total

@jlebon @mike-nguyen
ci/prow-entrypoint: tell git repo under /src is safe
3d9acd1 
That directory is part of the image and so not owned by us. Likely the
base image used for the src container was updated recently to include
newer git.

(cherry picked from commit 630d3f3)
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@mike-nguyen
Copy link
Member Author

cherry picked the /src is safe fix from the main development branch to fix CI in this PR.

c4rt0
c4rt0 approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@jlebon @mike-nguyen
c9s: pin selinux-policy-38.1.36-1.el9
ea765d6 
The latest selinux-policy breaks ISO tests:
openshift#1514

Pin to the previous working version for now.

To do this, introduce a new `overrides-c9s.yaml` manifest that we can
use going forward when we need to pin to older versions.

(cherry picked from commit 455ea2a)
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@mike-nguyen
Copy link
Member Author

Added jlebon's makeshift lock file pin for selinux-policy for c9s

jbtrystram
jbtrystram approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, jbtrystram, jlebon, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [c4rt0,jbtrystram,jlebon,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 28, 2024

@mike-nguyen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b01a02c into openshift:release-4.16 May 28, 2024
7 checks passed
@openshift-ci-robot
Copy link

@mike-nguyen: Jira Issue OCPBUGS-34026: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34026 has been moved to the MODIFIED state.

In response to this:

Start tracking the rhcos-4.16 branch of fedora-coreos-config as a part of branching 4.16.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbtrystram jbtrystram jbtrystram approved these changes

@c4rt0 c4rt0 c4rt0 approved these changes

@madhu-pillai madhu-pillai Awaiting requested review from madhu-pillai

@travier travier Awaiting requested review from travier

@aaradhak aaradhak Awaiting requested review from aaradhak

Assignees

@jlebon jlebon

@jbtrystram jbtrystram

@c4rt0 c4rt0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mike-nguyen @openshift-ci-robot @jlebon @jbtrystram @c4rt0