Make CentOS a build-time option again #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Big picture...we are going to cross a need for a freely available version. Otherwise too many things get painful; it's not easy for other people to contribute. So let's add CentOS back as an option. I split the host build in two. I also deleted the rhel repo as only RHT employees can use it today. And in general people will want to configure it anyways if they're doing custom builds.
openshift-ci-robot
added
the
size/L
|
/ok-to-test |
|
/test build |
Closed
|
/test build |
1 similar comment
|
/test build |
peterbaouoft
reviewed
May 7, 2018
| @@ -0,0 +1,30 @@ | |||
| -----BEGIN PGP PUBLIC KEY BLOCK----- | |||
There was a problem hiding this comment.
Minor: Hi, looks like this file is not being used? The container image will still use its own gpg key if we don't copy this file to /etc/pki/rpm-gpg/ right?
There was a problem hiding this comment.
Good catch! I think you're right. Though it might still be useful to keep it in the repo for folks composing locally, I guess?
|
It looks like this is working. So let's give it a try! /lgtm |
|
I'll set up a branch job that pushes the image somewhere for you guys today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big picture...we are going to cross a need for a freely
available version. Otherwise too many things get painful;
it's not easy for other people to contribute.
So let's add CentOS back as an option. I split the host
build in two. I also deleted the rhel repo as only RHT
employees can use it today. And in general people will
want to configure it anyways if they're doing custom
builds.