Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2094799: manifest: pull conmon from RHAOS repo for 4.9 #832

Merged

Conversation

HuijingHei
Copy link
Contributor

This allows us to land OCP specific changes to conmon and
potentially ship newer versions than what would available in the module.

This allows us to land OCP specific changes to conmon and
potentially ship newer versions than what would available in the module.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

manifest: pull conmon from RHAOS repo for 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuijingHei HuijingHei force-pushed the 49_conmon_rhaos branch 2 times, most recently from d9b417e to 8be3722 Compare June 8, 2022 10:07
@travier
Copy link
Member

travier commented Jun 8, 2022

/retitle Bug 2094799: manifest: pull conmon from RHAOS repo for 4.9

@openshift-ci openshift-ci bot changed the title manifest: pull conmon from RHAOS repo for 4.9 Bug 2094799: manifest: pull conmon from RHAOS repo for 4.9 Jun 8, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: This pull request references Bugzilla bug 2094799, which is invalid:

  • expected dependent Bugzilla bug 2094777 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2094781 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2094799: manifest: pull conmon from RHAOS repo for 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@travier
Copy link
Member

travier commented Jun 8, 2022

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@travier: This pull request references Bugzilla bug 2094799, which is invalid:

  • expected dependent Bugzilla bug 2094777 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
  • expected dependent Bugzilla bug 2094781 to target a release in 4.10.0, 4.10.z, but it targets "4.11.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@miabbott
Copy link
Member

miabbott commented Jun 8, 2022

Confirmed that the correct version of conmon was included in the build; most of the sanity tests passed (known issue about oudated cosa, see #830 (comment)). I think the rhcos.upgrade.from-ocp-rhcos failure is coreos/coreos-assembler#2830, which needs a backport to 4.9

/lgtm
/override ci/prow/build-test-qemu
/override ci/prow/validate
/honk

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@miabbott:
goose image

In response to this:

Confirmed that the correct version of conmon was included in the build; most of the sanity tests passed (known issue about oudated cosa, see #830 (comment)). I think the rhcos.upgrade.from-ocp-rhcos failure is coreos/coreos-assembler#2830, which needs a backport to 4.9

/lgtm
/override ci/prow/build-test-qemu
/override ci/prow/validate
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@miabbott: Overrode contexts on behalf of miabbott: ci/prow/build-test-qemu, ci/prow/validate

In response to this:

Confirmed that the correct version of conmon was included in the build; most of the sanity tests passed (known issue about oudated cosa, see #830 (comment)). I think the rhcos.upgrade.from-ocp-rhcos failure is coreos/coreos-assembler#2830, which needs a backport to 4.9

/lgtm
/override ci/prow/build-test-qemu
/override ci/prow/validate
/honk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 8, 2022

@HuijingHei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/build-test-qemu 6260899 link true /test build-test-qemu
ci/prow/validate 6260899 link true /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@miabbott
Copy link
Member

miabbott commented Jun 8, 2022

I think the rhcos.upgrade.from-ocp-rhcos failure is coreos/coreos-assembler#2830, which needs a backport to 4.9

This test didn't actually fail; must have mixed up looking at test results from #830

@sosiouxme
Copy link
Member

we will need this before next week's releases revert the conmon update...

@openshift-bot
Copy link

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@openshift-bot: This pull request references Bugzilla bug 2094799, which is invalid:

  • expected dependent Bugzilla bug 2094777 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mike-nguyen
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@mike-nguyen: This pull request references Bugzilla bug 2094799, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.z) matches configured target release for branch (4.9.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2094777 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 2094777 targets the "4.10.z" release, which is one of the valid target releases: 4.10.0, 4.10.z
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen June 9, 2022 01:52
@mike-nguyen
Copy link
Member

/approve

Copy link
Member

@mike-nguyen mike-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuijingHei, miabbott, mike-nguyen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [miabbott,mike-nguyen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 35e19a0 into openshift:release-4.9 Jun 9, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 9, 2022

@HuijingHei: All pull requests linked via external trackers have merged:

Bugzilla bug 2094799 has been moved to the MODIFIED state.

In response to this:

Bug 2094799: manifest: pull conmon from RHAOS repo for 4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@HuijingHei HuijingHei deleted the 49_conmon_rhaos branch June 9, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants