-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-595: overlay: Add rhcos-selinux-policy-upgrade.service
#962
OCPBUGS-595: overlay: Add rhcos-selinux-policy-upgrade.service
#962
Conversation
Skipping CI for Draft Pull Request. |
rhcos-selinux-policy-upgrade.service
rhcos-selinux-policy-upgrade.service
@cgwalters: This pull request references Jira Issue OCPBUGS-595, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@cgwalters: This pull request references Jira Issue OCPBUGS-595, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@cgwalters: This pull request references Jira Issue OCPBUGS-595, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
b1fd097
to
87e93c2
Compare
OK lifting draft, now tested manually, and I added an automated kola test. |
*) echo "Assuming we have new enough ostree"; exit 0;; | ||
esac | ||
|
||
ls -al /{usr/,}etc/selinux/targeted/policy/policy.31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure this is stable across all of our releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just above this, we exit if the OS isn't RHEL 8.[0-6]. This code very intentionally will not run on RHEL9, because we don't need it there.
/lgtm cancel |
OK, I've verified that it is |
/skip |
c43686d
to
95807f3
Compare
Hmm I swear I pushed a fix for the case of c9s yesterday, but not seeing it here. Anyways I just changed it to use |
95807f3
to
76ccbe2
Compare
Ahh I did push that attempted change but to the test code, not the core logic 🤦 - they're both similar looking shell scripts. Fixed. |
This will auto rebuild the policy if we detect local modifications; it is only needed before RHEL 8.7 when we'll pick up the combined underlying work from https://bugzilla.redhat.com/show_bug.cgi?id=2057497
76ccbe2
to
e974146
Compare
We might need to request more memory for this pod? |
That looks like another instance of coreos/coreos-assembler#2940 (comment) - more memory won't help, it's a 9p bug. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jmarrero, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Failed at the 3h mark due to timeout. |
/test ci/prow/rhcos-86-build-test-qemu |
@travier: The specified target(s) for
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test rhcos-86-build-test-qemu |
@cgwalters: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@cgwalters: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-595 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.11 |
@cgwalters: new pull request created: #966 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will auto rebuild the policy if we detect local modifications;
it is only needed before RHEL 8.7 when we'll pick up the
combined underlying work from
https://bugzilla.redhat.com/show_bug.cgi?id=2057497