Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go:embed for static yaml file #61

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

jsafrane
Copy link

Move from bindata to go:embed.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2021
@jsafrane
Copy link
Author

I don't understand why go 1.15 is used for unit/verify tests

@Gal-Zaidman
Copy link

/retest

Move from bindata to go:embed.
@jsafrane
Copy link
Author

Thanks! Edited .ci-operator.yaml...

@Gal-Zaidman
Copy link

/retest

3 similar comments
@Gal-Zaidman
Copy link

/retest

@Gal-Zaidman
Copy link

/retest

@Gal-Zaidman
Copy link

/retest

@Gal-Zaidman
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 22, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gal-Zaidman, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Gal-Zaidman,jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 81a7b36 into openshift:master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants