[release-4.6] Bug 1924623: pass ovirtClient to identity and remove redundant call to Test connection #69
Conversation
…o Test connection We didn't pass the ovirtClient to the identity on creation which caused a new connection to be created on each call to ovirtClient.GetConnection(). On top of that we called the Test function which is redundant since it is either a new connection or it is being called in the function. Those 2 errors caused the logs to get filled with auth requests and the evnet tab in the engine to get filled with auth events.
|
@openshift-cherrypick-robot: Bugzilla bug 1918287 has been cloned as Bugzilla bug 1924623. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
changed the title
openshift-ci-robot
added
bugzilla/severity-high
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1924623, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test e2e-ovirt |
1 similar comment
|
/test e2e-ovirt |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bennyz, Gal-Zaidman, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
(Patch-Manager) met criteria, approved. |
derekwaynecarr
added
the
cherry-pick-approved
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1924623 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #67
/assign Gal-Zaidman