Skip to content

Commit

Permalink
Merge pull request #313 from danwinship/fix-ipv6-mac-hack-45
Browse files Browse the repository at this point in the history
Bug 1888352: Fix IPv6 neighbor discovery hack
  • Loading branch information
openshift-merge-robot committed Oct 22, 2020
2 parents 2f2678d + 204e2b2 commit 1fe1747
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions go-controller/pkg/node/gateway_localnet.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func initLocalnetGateway(nodeName string, subnet *net.IPNet, wf *factory.WatchFa
", stderr:%s (%v)", localnetBridgeName, stderr, err)
}

ifaceID, macAddress, err := bridgedGatewayNodeSetup(nodeName, localnetBridgeName, localnetBridgeName, true)
ifaceID, _, err := bridgedGatewayNodeSetup(nodeName, localnetBridgeName, localnetBridgeName, true)
if err != nil {
return fmt.Errorf("failed to set up shared interface gateway: %v", err)
}
Expand Down Expand Up @@ -204,7 +204,7 @@ func initLocalnetGateway(nodeName string, subnet *net.IPNet, wf *factory.WatchFa
if utilnet.IsIPv6CIDR(subnet) {
// TODO - IPv6 hack ... for some reason neighbor discovery isn't working here, so hard code a
// MAC binding for the gateway IP address for now - need to debug this further
err = util.LinkNeighAdd(link, gatewayIP, macAddress)
err = util.LinkNeighAdd(link, gatewayIP, gwMacAddress)
if err == nil {
klog.Infof("Added MAC binding for %s on %s", gatewayIP, localnetGatewayNextHopPort)
} else {
Expand Down

0 comments on commit 1fe1747

Please sign in to comment.