Bug 1888352: Fix IPv6 neighbor discovery hack #313

danwinship · 2020-10-19T17:29:49Z

Fixes an IPv6 regression introduced by #238

openshift-ci-robot · 2020-10-19T17:30:05Z

@danwinship: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP Fix IPv6 neighbor discovery hack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-19T17:43:31Z

@danwinship: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP Fix IPv6 neighbor discovery hack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-19T19:39:10Z

@danwinship: This pull request references Bugzilla bug 1888352, which is invalid:

expected Bugzilla bug 1888352 to depend on a bug targeting a release in 4.6.0, 4.6.z and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1888352: Fix IPv6 neighbor discovery hack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

danwinship · 2020-10-19T19:41:58Z

/bugzilla refresh

openshift-ci-robot · 2020-10-19T19:42:06Z

@danwinship: This pull request references Bugzilla bug 1888352, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1889507 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1889507 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-10-19T19:43:24Z

@danwinship: This pull request references Bugzilla bug 1888352, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.z) matches configured target release for branch (4.5.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1889507 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1889507 targets the "4.6.z" release, which is one of the valid target releases: 4.6.0, 4.6.z
bug has dependents

In response to this:

Bug 1888352: Fix IPv6 neighbor discovery hack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trozet · 2020-10-19T20:06:13Z

/lgtm

openshift-ci-robot · 2020-10-19T20:06:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-10-19T20:40:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stbenjam · 2020-10-19T23:35:21Z

/refresh

openshift-ci-robot · 2020-10-19T23:35:27Z

@danwinship: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-ovn	`204e2b2`	link	`/test e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

stbenjam · 2020-10-19T23:36:03Z

/test e2e-aws-ovn

openshift-bot · 2020-10-20T02:57:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-20T03:10:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-20T04:28:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-20T05:46:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-20T07:17:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

elfosardo · 2020-10-20T08:58:18Z

/test e2e-aws-ovn

openshift-bot · 2020-10-20T10:32:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-20T12:16:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

stbenjam · 2020-10-20T13:48:31Z

@danwinship Is the aws-ovn failure legit? It looks like the last periodics on 4.5 have passed aws-ovn, but it's consistently failing here.

openshift-bot · 2020-10-20T14:00:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-20T15:44:08Z

/retest

Please review the full test history for this PR and help us cut down flakes.

danwinship · 2020-10-20T16:51:35Z

/override ci/prow/e2e-aws-ovn

Each run is failing different tests. I think it's just really flaky. ☹️
And the PR only affects IPv6 anyway, so it's definitely not the cause of the e2e-aws-ovn failure

openshift-ci-robot · 2020-10-20T16:52:05Z

@danwinship: Overrode contexts on behalf of danwinship: ci/prow/e2e-aws-ovn

In response to this:

/override ci/prow/e2e-aws-ovn

Each run is failing different tests. I think it's just really flaky. ☹️
And the PR only affects IPv6 anyway, so it's definitely not the cause of the e2e-aws-ovn failure

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

stbenjam · 2020-10-20T19:20:08Z

Tide isn't reporting status to GitHub, but I guess it's still doing it's thing. We need a cherry-pick-approved label. Not sure if anyone wants to try to bug the patch manager about it, but I would guess they should get to it soon since severity is urgent.

openshift-bot · 2020-10-22T02:36:29Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-22T02:49:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-22T03:44:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-22T04:10:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

elfosardo · 2020-10-22T06:56:27Z

/test e2e-aws-ovn

openshift-bot · 2020-10-22T06:59:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

elfosardo · 2020-10-22T08:30:54Z

/test e2e-aws-ovn

openshift-bot · 2020-10-22T09:48:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

elfosardo · 2020-10-22T11:08:27Z

/test e2e-aws-ovn

openshift-ci-robot · 2020-10-22T12:34:34Z

@danwinship: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#313

Bugzilla bug 1888352 has been moved to the MODIFIED state.

In response to this:

Bug 1888352: Fix IPv6 neighbor discovery hack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2020

openshift-ci-robot requested review from alexanderConstantinescu and dcbw October 19, 2020 17:30

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2020

Fix IPv6 neighbor discovery hack

204e2b2

danwinship force-pushed the fix-ipv6-mac-hack-45 branch from 547655b to 204e2b2 Compare October 19, 2020 17:42

danwinship changed the title ~~WIP Fix IPv6 neighbor discovery hack~~ Bug 1888352: Fix IPv6 neighbor discovery hack Oct 19, 2020

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 19, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 19, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 19, 2020

openshift-ci-robot assigned trozet Oct 19, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2020

bparees added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 21, 2020

openshift-merge-robot merged commit 1fe1747 into openshift:release-4.5 Oct 22, 2020

danwinship deleted the fix-ipv6-mac-hack-45 branch October 22, 2020 12:36

Bug 1888352: Fix IPv6 neighbor discovery hack #313

Bug 1888352: Fix IPv6 neighbor discovery hack #313

Conversation

danwinship commented Oct 19, 2020 • edited

openshift-ci-robot commented Oct 19, 2020

openshift-ci-robot commented Oct 19, 2020

openshift-ci-robot commented Oct 19, 2020

danwinship commented Oct 19, 2020

openshift-ci-robot commented Oct 19, 2020

openshift-ci-robot commented Oct 19, 2020

trozet commented Oct 19, 2020

openshift-ci-robot commented Oct 19, 2020

openshift-bot commented Oct 19, 2020

stbenjam commented Oct 19, 2020

openshift-ci-robot commented Oct 19, 2020

stbenjam commented Oct 19, 2020

openshift-bot commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

elfosardo commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

stbenjam commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

openshift-bot commented Oct 20, 2020

danwinship commented Oct 20, 2020

openshift-ci-robot commented Oct 20, 2020

stbenjam commented Oct 20, 2020 • edited

openshift-bot commented Oct 22, 2020

openshift-bot commented Oct 22, 2020

openshift-bot commented Oct 22, 2020

openshift-bot commented Oct 22, 2020

elfosardo commented Oct 22, 2020

openshift-bot commented Oct 22, 2020

elfosardo commented Oct 22, 2020

openshift-bot commented Oct 22, 2020

elfosardo commented Oct 22, 2020

openshift-ci-robot commented Oct 22, 2020

danwinship commented Oct 19, 2020 •

edited

stbenjam commented Oct 20, 2020 •

edited