Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2070674: improve performance of service sync #1110

Merged
merged 2 commits into from Jun 2, 2022
Merged

Bug 2070674: improve performance of service sync #1110

merged 2 commits into from Jun 2, 2022

Conversation

jcaamano
Copy link
Contributor

Cherry-pick the following upstream PRs to improve performance of services synchronization:

ovn-org/ovn-kubernetes#2963
ovn-org/ovn-kubernetes#2978

@jcaamano
libovsdbops: only one wait per txn
e490188 
Transactions is an all or nothing thing so we just need one wait per
transaction to check against duplicates.

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
(cherry picked from commit 1aaad50)
@jcaamano
Don't lookup LBs that don't exist in cache
c4a539b 
Running the LB predicate that matches on name takes a long time if the
LB table has many LBs. For example, looking up ~40 LBs in a table with
~200k rows took aproximately 3s.

The service controller has a second level cache and knows which LBs need
to be added and which need to be updated. Avoid this lookup for LBs that
are to be added.

Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
(cherry picked from commit 0573fe5)
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@jcaamano: This pull request references Bugzilla bug 2070674, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2070674: improve performance of service sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from trozet and tssurya May 27, 2022 08:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@jcaamano
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@jcaamano: An error was encountered adding this pull request to the external tracker bugs for bug 2070674 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 503 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@jcaamano: An error was encountered adding this pull request to the external tracker bugs for bug 2070674 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. response code 503 not 200

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 27, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2022

@jcaamano: This pull request references Bugzilla bug 2070674, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor

/retest-required

@flavio-fernandes
Copy link
Contributor

/lgtm

❯ git co c949a6823
Previous HEAD position was c4a539b26 Don't lookup LBs that don't exist in cache
HEAD is now at c949a6823 Merge pull request #1108 from zshi-redhat/bz2090537
❯ git co -b jaime_backport
Switched to a new branch 'jaime_backport'
❯ git cherry-pick 1aaad50f0cba45967444c88a623c5b97b926d60a
❯ git cherry-pick 0573fe590a6f307200dc61a9cd0a6409db754c3d
❯ git diff downstream/pr/1110 | wc -l
0

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, jcaamano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 938d2a7 and 8 for PR HEAD c4a539b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 938d2a7 and 7 for PR HEAD c4a539b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 938d2a7 and 6 for PR HEAD c4a539b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 4e57473 and 5 for PR HEAD c4a539b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 4e57473 and 4 for PR HEAD c4a539b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4e57473 and 3 for PR HEAD c4a539b in total

@jcaamano
Copy link
Contributor Author

jcaamano commented Jun 1, 2022

/retest-required

@jcaamano
Copy link
Contributor Author

jcaamano commented Jun 1, 2022

/override ci/prow/e2e-aws-ovn-windows

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2022

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD f88113a and 2 for PR HEAD c4a539b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD f88113a and 1 for PR HEAD c4a539b in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD f88113a and 0 for PR HEAD c4a539b in total

@jcaamano
Copy link
Contributor Author

jcaamano commented Jun 2, 2022

/override ci/prow/e2e-aws-ovn-windows

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-aws-ovn-windows

In response to this:

/override ci/prow/e2e-aws-ovn-windows

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022 •
edited

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn c4a539b link false /test e2e-openstack-ovn
ci/prow/e2e-hypershift c4a539b link false /test e2e-hypershift
ci/prow/e2e-ovn-hybrid-step-registry c4a539b link false /test e2e-ovn-hybrid-step-registry
ci/prow/e2e-vsphere-ovn c4a539b link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-windows c4a539b link false /test e2e-vsphere-windows
ci/prow/okd-e2e-gcp-ovn c4a539b link false /test okd-e2e-gcp-ovn
ci/prow/4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade c4a539b link false /test 4.11-upgrade-from-stable-4.10-local-gateway-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jcaamano
Copy link
Contributor Author

jcaamano commented Jun 2, 2022

/retest-required

@openshift-merge-robot openshift-merge-robot merged commit db7c0d7 into openshift:master Jun 2, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2022

@jcaamano: All pull requests linked via external trackers have merged:

Bugzilla bug 2070674 has been moved to the MODIFIED state.

In response to this:

Bug 2070674: improve performance of service sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano
Copy link
Contributor Author

jcaamano commented Jul 6, 2022

/cherry-pick release-4.10

@openshift-cherrypick-robot
Copy link

@jcaamano: #1110 failed to apply on top of branch "release-4.10":

Applying: libovsdbops: only one wait per txn
Using index info to reconstruct a base tree...
M	go-controller/pkg/libovsdbops/model_client.go
M	go-controller/pkg/libovsdbops/model_client_test.go
Falling back to patching base and 3-way merge...
Auto-merging go-controller/pkg/libovsdbops/model_client_test.go
CONFLICT (content): Merge conflict in go-controller/pkg/libovsdbops/model_client_test.go
Auto-merging go-controller/pkg/libovsdbops/model_client.go
CONFLICT (content): Merge conflict in go-controller/pkg/libovsdbops/model_client.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 libovsdbops: only one wait per txn
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcaamano jcaamano mentioned this pull request Jul 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trozet trozet Awaiting requested review from trozet

@tssurya tssurya Awaiting requested review from tssurya

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@flavio-fernandes flavio-fernandes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jcaamano @flavio-fernandes @openshift-ci-robot @openshift-cherrypick-robot @openshift-merge-robot