libovsdbops: only one wait per txn #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions is an all or nothing thing so we just need one wait per transaction to check against duplicates. Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>
|
Only concern I have is if multiple doWhenNotFound() happen to run at the same time... maybe that's not a concern here though. |
Yeah, not a concern I would say, they run one after another. |
trozet
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions is an all or nothing thing so we just need one wait per transaction to check against duplicate transactions that might happen on transaction retries or other OVN glitches. This prevents massive delays on transactions that bundled several LB inserts, and thus several Wait ops, from the service controller.
However, for genuine reasons to prevent duplicate rows, like inserting the same row from multiple threads, this requires to have them by themselves on their own transaction.