Bug 2094088: Fixes Updating non-default columns as well as libovsdb fixes for empty values #1146
Conversation
Reverts part of ovn-org/ovn-kubernetes#2800 onModelUpdatesAll was not really updating all...only things that had non default values. Therefore if there was an update operation using onModelUpdatesAll, where the desired update was to set a column back to its default state, it would be ignored. This true for specific types like maps, slices and pointers. This commit reverts the behavior to its previous state before onModelUpdatesAll was added. Additionally for those models which used the same behavior of only updating default previously, onModelUpdatesAll is renamed to onModelUpdatesAllNonDefault. In the future, someone may want to implement a real onModelUpdatesAll function which would dynamically figure out all of the fields of a model to update and return that list. For now the code is commented with TODOs and reverted back to its previous state. Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 5d84deb)
Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 2796c94)
Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit aacdd6e)
The test "reconciles a deleted pod referenced by a networkpolicy in another namespace" was never actually changing the expected data in libovsdb after deleting the pod. Due to a race the check would sometimes just work if the policy had not updated after the pod delete yet. Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit b89fb48)
Signed-off-by: Tim Rozet <trozet@redhat.com> (cherry picked from commit 292b884)
|
/assign @jcaamano |
openshift-ci
bot
added
bugzilla/severity-urgent
|
@trozet: This pull request references Bugzilla bug 2094088, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcaamano, trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@trozet: All pull requests linked via external trackers have merged: Bugzilla bug 2094088 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pulls in fixes to ensure we always set columns back to default values as well as the fix for libovsdb which correctly interprets empty values for pointers.