Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2100507: Remove redundant log lines in obj_retry.go #1162

Merged
merged 1 commit into from
Jul 8, 2022
Merged

Bug 2100507: Remove redundant log lines in obj_retry.go #1162

merged 1 commit into from
Jul 8, 2022

Conversation

ricky-rav
Copy link
Contributor

clean cherry pick

Signed-off-by: Riccardo Ravaioli rravaiol@redhat.com
(cherry picked from commit 8df383b)

fixes #2100507

@ricky-rav
Remove redundant log lines in obj_retry.go
c52b652 
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
(cherry picked from commit 8df383b)
@openshift-ci openshift-ci bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@ricky-rav: This pull request references Bugzilla bug 2100507, which is invalid:

  • expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2100507: Remove redundant log lines in obj_retry.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricky-rav
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

@ricky-rav: This pull request references Bugzilla bug 2100507, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flavio-fernandes
flavio-fernandes reviewed Jun 23, 2022
View reviewed changes
Copy link
Contributor

@flavio-fernandes flavio-fernandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2022
@dcbw
Copy link
Contributor

dcbw commented Jun 23, 2022

/approve
/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, flavio-fernandes, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 13f9329 and 8 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 13f9329 and 7 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 13f9329 and 6 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD dd08aab and 5 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD dd08aab and 4 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD dd08aab and 3 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 6cce6d8 and 2 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 6cce6d8 and 1 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6cce6d8 and 0 for PR HEAD c52b652 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 6, 2022 •
edited
Loading

@ricky-rav: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-gcp-ovn c52b652 link false /test okd-e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn c52b652 link false /test e2e-vsphere-ovn
ci/prow/e2e-vsphere-windows c52b652 link false /test e2e-vsphere-windows
ci/prow/e2e-openstack-ovn c52b652 link false /test e2e-openstack-ovn
ci/prow/e2e-hypershift c52b652 link false /test e2e-hypershift
ci/prow/e2e-aws-ovn-windows c52b652 link false /test e2e-aws-ovn-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

/hold

Revision c52b652 was retested 9 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 6, 2022
@ricky-rav
Copy link
Contributor Author

/retest-required

@ricky-rav
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2022
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 0f9ee95 and 8 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 0f9ee95 and 7 for PR HEAD c52b652 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 0f9ee95 and 6 for PR HEAD c52b652 in total

@openshift-ci openshift-ci bot merged commit 977f7bd into openshift:master Jul 8, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 8, 2022

@ricky-rav: All pull requests linked via external trackers have merged:

Bugzilla bug 2100507 has been moved to the MODIFIED state.

In response to this:

Bug 2100507: Remove redundant log lines in obj_retry.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavio-fernandes flavio-fernandes flavio-fernandes left review comments

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@abhat abhat Awaiting requested review from abhat

@trozet trozet Awaiting requested review from trozet

Assignees

@flavio-fernandes flavio-fernandes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ricky-rav @dcbw @openshift-ci-robot @flavio-fernandes