New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.11] Bug 2109642: two hybrid overlay fixes #1209
[release-4.11] Bug 2109642: two hybrid overlay fixes #1209
Conversation
in the hybrid overlay there was a comma missing from a flow between the nw_src and action. Adding the comma fixes the flow. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com> (cherry picked from commit 0582cf4)
in 854a7eb a variable was added to the node controller gwLRPIP that was read from an annotation. THis annotation is added by the master after the node was created. Unfortunatly the node controller only reacts to the Nodes creation and not updates so change the reading of the annotation and finish initializing on pod creation. Signed-off-by: Jacob Tanenbaum <jtanenba@redhat.com> (cherry picked from commit 6201311)
@dcbw: This pull request references Bugzilla bug 2109642, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@dcbw: This pull request references Bugzilla bug 2109642, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@dcbw: This pull request references Bugzilla bug 2109642, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@JacobTanenbaum: This pull request references Bugzilla bug 2109642, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@JacobTanenbaum: This pull request references Bugzilla bug 2109642, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@dcbw: This pull request references Bugzilla bug 2109642, which is valid. 6 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, JacobTanenbaum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label qe-approved |
/retest-required |
/retest-required |
@dcbw: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest-required |
@dcbw: All pull requests linked via external trackers have merged: Bugzilla bug 2109642 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-pick of ovn-org/ovn-kubernetes#3063 from upstream.
A missing comma before an "action=" meant that those OVS flows weren't getting added due to a parsing error.
Second, the
k8s.ovn.org/node-gateway-router-lrp-ifaddr
annotation added by ovn-org/ovn-kubernetes#2862 was only evaluated on node add, but we can't always rely on that. It might be added slightly later in an Update event.