Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2109945: [Downstream Merge: 04-08-2022] #1231

Merged
merged 8 commits into from Aug 5, 2022
Merged

Bug 2109945: [Downstream Merge: 04-08-2022] #1231

merged 8 commits into from Aug 5, 2022

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Aug 3, 2022

andreaskaris and others added 8 commits July 28, 2022 11:47
@andreaskaris
EgressIP: Merge ops into pendingCloudPrivateIPConfigsOps on add
e16d3e5 
Merge the add op into the existing map but only execute new
operations.
Up until now, the Cloud Private IP Conf add operation unconditionally
overwrote the current entry in pendingCloudPrivateIPConfigsOps for
the egressIPName. This lead to race conditions when updating an
EgressIP's IP address to a different one. During such a simultaneous
CloudPrivateIP add and remove operation, the add could overwrite the
map entry before the remove had the time to remove its own op.
The delete operation would be rescheduled and log an error until the
reschedule was killed off.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2105706
@andreaskaris
EgressIP: Do not throw error on API IsNotFound
3d69f04 
Do not throw an error when the cache contains a delete operation
for an IsNotFound API object. Instead, log an Info and go on with
the business logic. The desired state is already == the current
state, so there is no reason to throw an error and retry in such
a scenario.

Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@andreaskaris
Enable CNCC in OVNK
b1c7bef 
Signed-off-by: Andreas Karis <ak.karis@gmail.com>
@trozet
Merge pull request #3099 from andreaskaris/enable-cncc-ovnk-upstream
eeef017 
Enable CNCC in OVNK
@pliurh
Revert "Remove stale chassis for hosts that run ovnkube-node on DPU"
d4158df 
This reverts commit 9086e57.
As the community decided not to add any DB client to the node, revert
the commit first. A new fix will be proposed later.

Signed-off-by: Peng Liu <pliu@redhat.com>
@jcaamano
Merge pull request #3103 from pliurh/revert
51ef7fe 
Revert "Remove stale chassis for hosts that run ovnkube-node on DPU"
@jcaamano
Merge pull request #3066 from andreaskaris/bz2105706
72e3558 
Bug 2105706: EgressIP: Merge ops into pendingCloudPrivateIPConfigsOps on add
@tssurya
Merge remote-tracking branch 'ovnorg/master' into merge-04-08-2022
fe9e7b0
@tssurya tssurya mentioned this pull request Aug 3, 2022
Closed
@openshift-ci openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 3, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 3, 2022

@tssurya: This pull request references Bugzilla bug 2109945, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.12.0) matches configured target release for branch (4.12.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Bug 2109945: [Downstream Merge: 04-08-2022]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 4, 2022
@dcbw
Copy link
Member

dcbw commented Aug 4, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, tssurya, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@tssurya
Copy link
Contributor Author

tssurya commented Aug 4, 2022

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD ff769ef and 8 for PR HEAD fe9e7b0 in total

@alvaroaleman
Copy link
Contributor

/test e2e-hypershift

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD ff769ef and 7 for PR HEAD fe9e7b0 in total

@tssurya
Copy link
Contributor Author

tssurya commented Aug 4, 2022

/test e2e-hypershift

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD ff769ef and 6 for PR HEAD fe9e7b0 in total

@alvaroaleman
Copy link
Contributor

/retest-required

2 similar comments
@alvaroaleman
Copy link
Contributor

/retest-required

@zshi-redhat
Copy link
Contributor

/retest-required

@andreaskaris
Copy link
Contributor

/retest-required

@andreaskaris
Copy link
Contributor

/retest

@andreaskaris
Copy link
Contributor

/retest-required

@dcbw
Copy link
Member

dcbw commented Aug 5, 2022

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-ovn-dualstack

level=debug msg=ironic_node_v1.openshift-master-host[1]: Still creating... [1h36m11s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[2]: Still creating... [1h36m11s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[1]: Still creating... [1h36m21s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[0]: Still creating... [1h36m21s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[2]: Still creating... [1h36m21s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[0]: Still creating... [1h36m31s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[1]: Still creating... [1h36m31s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[2]: Still creating... [1h36m31s elapsed]
bash: line 66: 16447 Killed                  timeout -s 9 105m make

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-metal-ipi-ovn-dualstack, ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-ipv6
/override ci/prow/e2e-metal-ipi-ovn-dualstack

level=debug msg=ironic_node_v1.openshift-master-host[1]: Still creating... [1h36m11s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[2]: Still creating... [1h36m11s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[1]: Still creating... [1h36m21s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[0]: Still creating... [1h36m21s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[2]: Still creating... [1h36m21s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[0]: Still creating... [1h36m31s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[1]: Still creating... [1h36m31s elapsed]
level=debug msg=ironic_node_v1.openshift-master-host[2]: Still creating... [1h36m31s elapsed]
bash: line 66: 16447 Killed                  timeout -s 9 105m make

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 8deda7a into openshift:master Aug 5, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@tssurya: All pull requests linked via external trackers have merged:

Bugzilla bug 2109945 has been moved to the MODIFIED state.

In response to this:

Bug 2109945: [Downstream Merge: 04-08-2022]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2022

@tssurya: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift fe9e7b0 link false /test e2e-hypershift
ci/prow/okd-e2e-gcp-ovn fe9e7b0 link false /test okd-e2e-gcp-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@JacobTanenbaum JacobTanenbaum Awaiting requested review from JacobTanenbaum

@trozet trozet Awaiting requested review from trozet

Assignees

@zshi-redhat zshi-redhat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@tssurya @zshi-redhat @dcbw @openshift-ci-robot @alvaroaleman @andreaskaris @trozet @pliurh @jcaamano