Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-2303: [4.11] Stale chassis are not removed #1310

Merged
merged 1 commit into from
Mar 24, 2023
Merged

OCPBUGS-2303: [4.11] Stale chassis are not removed #1310

merged 1 commit into from
Mar 24, 2023

Conversation

bn222
Copy link
Contributor

@bn222 bn222 commented Oct 13, 2022

Missing backport

@pliurh @bn222
Remove stale chassis for hosts that run ovnkube-node on DPU
7fc060d 
In the DPU 2-clusters design, a host with DPU will join the cluster
with ovn-controller running in the host first, then it will be moved
to the DPU. Therefore, we will have 2 chassis with the same hostname
in the ovn sbdb.

With this patch, the master will try to remove the stale chassis when
the Chassis ID is inconsistent with the value of node annotation
'k8s.ovn.org/node-chassis-id'.

Signed-off-by: Peng Liu <pliu@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@bn222: This pull request references Jira Issue OCPBUGS-2303, which is invalid:

  • expected Jira Issue OCPBUGS-2303 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Missing backport

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2022

@bn222: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-2303: Stale chassis are not removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bn222
Copy link
Contributor Author

bn222 commented Oct 13, 2022

@pliurh

@openshift-ci openshift-ci bot requested review from dcbw and trozet October 13, 2022 07:54
@bn222
Copy link
Contributor Author

bn222 commented Oct 13, 2022

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@bn222: This pull request references Jira Issue OCPBUGS-2303, which is invalid:

  • expected Jira Issue OCPBUGS-2303 to depend on a bug targeting a version in 4.12.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bn222
Copy link
Contributor Author

bn222 commented Oct 13, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 13, 2022
@openshift-ci-robot
Copy link
Contributor

@bn222: This pull request references Jira Issue OCPBUGS-2303, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2304 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2304 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bn222
Copy link
Contributor Author

bn222 commented Oct 13, 2022

@zshi-redhat

@zshi-redhat
Copy link
Contributor

/retest

@dcbw
Copy link
Contributor

dcbw commented Oct 13, 2022

/approve
/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bn222, dcbw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2022
@dcbw
Copy link
Contributor

dcbw commented Nov 11, 2022

/retest

1 similar comment
@bn222
Copy link
Contributor Author

bn222 commented Nov 15, 2022

/retest

@dcbw dcbw changed the title OCPBUGS-2303: Stale chassis are not removed OCPBUGS-2303: [4.11] Stale chassis are not removed Nov 29, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

@bn222: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to this:

OCPBUGS-2303: [4.11] Stale chassis are not removed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Feb 7, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2023
@openshift-ci-robot
Copy link
Contributor

@dcbw: This pull request references Jira Issue OCPBUGS-2303, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.11.z) matches configured target version for branch (4.11.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-2304 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE))
  • dependent Jira Issue OCPBUGS-2304 targets the "4.12.0" version, which is one of the valid target versions: 4.12.0, 4.12.z
  • bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw dcbw added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 7, 2023
@dcbw
Copy link
Contributor

dcbw commented Feb 22, 2023

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 22, 2023

@bn222: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 7fc060d link false /test e2e-hypershift
ci/prow/e2e-vsphere-windows 7fc060d link false /test e2e-vsphere-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 22, 2023
@trozet
Copy link
Contributor

trozet commented Mar 23, 2023

/tide refresh

@trozet
Copy link
Contributor

trozet commented Mar 23, 2023

/skip

@trozet
Copy link
Contributor

trozet commented Mar 23, 2023

/override ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-e2e-aws-ovn-upgrade
/override ci/prow/4.12-upgrade-from-stable-4.11-images
/override ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade

@trozet
Copy link
Contributor

trozet commented Mar 23, 2023

/override ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

@trozet: Overrode contexts on behalf of trozet: ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade, ci/prow/4.12-upgrade-from-stable-4.11-images, ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-e2e-aws-ovn-upgrade

In response to this:

/override ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-e2e-aws-ovn-upgrade
/override ci/prow/4.12-upgrade-from-stable-4.11-images
/override ci/prow/4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 23, 2023

@trozet: Overrode contexts on behalf of trozet: ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-images

In response to this:

/override ci/prow/4.12-upgrade-from-stable-4.11-local-gateway-images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD eae2cb3 and 2 for PR HEAD 7fc060d in total

@openshift-merge-robot openshift-merge-robot merged commit 0ff2f3b into openshift:release-4.11 Mar 24, 2023
@openshift-ci-robot
Copy link
Contributor

@bn222: Jira Issue OCPBUGS-2303: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-2303 has been moved to the MODIFIED state.

In response to this:

Missing backport

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcbw dcbw Awaiting requested review from dcbw

@trozet trozet Awaiting requested review from trozet

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@dcbw dcbw

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@yingwang-0320 yingwang-0320

@qiowang721 qiowang721

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.