OCPBUGS-11701: [release-4.12] CARRY: use "prefer local" for annotated services #1638
Conversation
Openshift hack: the router service is annotated with "traffic-policy.network.alpha.openshift.io/local-with-fallback" because, while it is defined with externalTrafficPolicy=Local, it expects the CNI to switch to externalTrafficPolicy=Cluster as soon as there are no local endpoints on any given node. SDN does this already, let's do it in OVNK as well to further reduce disruption time to openshift ingress during upgrades. Co-authored-by: Riccardo Ravaioli <rravaiol@redhat.com> Co-authored-by: Surya Seetharaman <suryaseetharaman.9@gmail.com> (cherry picked from commit c521311)
|
@ricky-rav: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/jira cherrypick OCPBUGS-11458 |
|
@ricky-rav: Jira Issue OCPBUGS-11458 has been cloned as Jira Issue OCPBUGS-11701. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
changed the title
|
@ricky-rav: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
jira/severity-moderate
|
@ricky-rav: This pull request references Jira Issue OCPBUGS-11701, which is valid. The bug has been moved to the POST state. 6 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ricky-rav
changed the title
|
@ricky-rav: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest-required |
|
/approve |
dcbw
added
the
backport-risk-assessed
openshift-ci
bot
assigned anuragthehatter, asood-rh, huiran0826, jechen0648, mffiedler, qiowang721, rbbratta, weliang1, yingwang-0320 and zhaozhanqi
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, ricky-rav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/label cherry-pick-approved |
openshift-ci
bot
added
the
cherry-pick-approved
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
|
/override ci/prow/e2e-vsphere-windows |
|
@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-vsphere-windows In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ricky-rav: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/tide refresh |
|
@ricky-rav: Jira Issue OCPBUGS-11701: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-11701 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Fix included in accepted release 4.12.0-0.nightly-2023-04-14-233647 |
Backport of #1630 for 4.12.
Clean backport for the hack itself in
go-controller/pkg/ovn/controller/services/load_balancer.go, not a clean backport of the unit tests just because:LBRule,LB,LBOpts,Addrhad to be prefixed withovnlb.go-controller/pkg/ovn/controller/services/load_balancer_ocphack_test.goin 4.12, so I moved the unit tests to the existinggo-controller/pkg/ovn/controller/services/load_balancer_test.goright after the other ocp hack.Openshift hack: the router service is annotated with "traffic-policy.network.alpha.openshift.io/local-with-fallback" because, while it is defined with externalTrafficPolicy=Local, it expects the CNI to switch to externalTrafficPolicy=Cluster as soon as there are no local endpoints on any given node. SDN does this already, let's do it in OVNK as well to further reduce disruption time to openshift ingress during upgrades.
Co-authored-by: Riccardo Ravaioli rravaiol@redhat.com
Co-authored-by: Surya Seetharaman suryaseetharaman.9@gmail.com
(cherry picked from commit c521311)