Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-25486: Fix Egress IP Deletion Handler to Prevent OVN Policy Leaks #1999

Conversation

flavio-fernandes
Copy link
Contributor

Clean cherry pick from commit db4aaf4 (via #1990)

Resolved an issue where the Egress IP deletion handler misidentified affected pods, leading to unintended leaks of OVN logical router policies and SNATs. This occurred in scenarios with matchExpressions that only excluded keys and values.

Resolved an issue where the Egress IP deletion handler
misidentified affected pods, leading to unintended
leaks of OVN logical router policies and SNATs. This
occurred in scenarios with matchExpressions that only
excluded keys and values.

Reported-at: https://issues.redhat.com/browse/OCPBUGS-24055
Signed-off-by: Flavio Fernandes <flaviof@redhat.com>
(cherry picked from commit db4aaf4)
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 21, 2023
@openshift-ci-robot
Copy link
Contributor

@flavio-fernandes: This pull request references Jira Issue OCPBUGS-25486, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-24055 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-24055 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Clean cherry pick from commit db4aaf4 (via #1990)

Resolved an issue where the Egress IP deletion handler misidentified affected pods, leading to unintended leaks of OVN logical router policies and SNATs. This occurred in scenarios with matchExpressions that only excluded keys and values.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor Author

/cherry-pick release-4.14

@openshift-cherrypick-robot

@flavio-fernandes: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flavio-fernandes
Copy link
Contributor Author

/assign @tssurya

Copy link
Contributor

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed
/approve

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Dec 21, 2023
@openshift-ci openshift-ci bot requested review from abhat and tssurya December 21, 2023 15:05
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flavio-fernandes
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Dec 22, 2023

@flavio-fernandes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 56d1fe4 link false /test security
ci/prow/e2e-aws-ovn-kubevirt 56d1fe4 link false /test e2e-aws-ovn-kubevirt
ci/prow/e2e-vsphere-ovn 56d1fe4 link false /test e2e-vsphere-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@flavio-fernandes
Copy link
Contributor Author

/retest-required

@anuragthehatter
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 31, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit e6ba47f into openshift:release-4.15 Dec 31, 2023
25 of 28 checks passed
@openshift-ci-robot
Copy link
Contributor

@flavio-fernandes: Jira Issue OCPBUGS-25486: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-25486 has been moved to the MODIFIED state.

In response to this:

Clean cherry pick from commit db4aaf4 (via #1990)

Resolved an issue where the Egress IP deletion handler misidentified affected pods, leading to unintended leaks of OVN logical router policies and SNATs. This occurred in scenarios with matchExpressions that only excluded keys and values.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@flavio-fernandes: new pull request created: #2003

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202312310210.p0.ge6ba47f.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

@flavio-fernandes flavio-fernandes deleted the eip_fix_excluding_matches-release-4.15 branch January 2, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.