OCPBUGS-27925: dont quit if node does not have subnet annotation

[jluhrsen]

in some cases, multiple nodes will have to sync and we may not have enough subnets available for all of them. In that case we don't want to quit the sync on other nodes if one is found to not have the subnet annotation as the others may still have it.

Also moves log message for duration of different syncs to the end of their sync so it will only print once.

JIRA: https://issues.redhat.com/browse/OCPBUGS-18598

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

[jluhrsen]

/retest

[jluhrsen]

/retest

[openshift-ci]

@jluhrsen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	704c7b9	link	false	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-27925, which is invalid:

• expected Jira Issue OCPBUGS-27925 to depend on a bug targeting a version in 4.15.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

in some cases, multiple nodes will have to sync and we may not have enough subnets available for all of them. In that case we don't want to quit the sync on other nodes if one is found to not have the subnet annotation as the others may still have it.

Also moves log message for duration of different syncs to the end of their sync so it will only print once.

JIRA: https://issues.redhat.com/browse/OCPBUGS-18598

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jluhrsen]

/jira refresh

[openshift-ci-robot]

@jluhrsen: This pull request references Jira Issue OCPBUGS-27925, which is valid.

6 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.14.z) matches configured target version for branch (4.14.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• dependent bug Jira Issue OCPBUGS-18598 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-18598 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jechen@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tssurya]

@jluhrsen : did you cherry-pick this?
we usually preserve history which means you must cherry-pick b2bfdf1 with the -x option so that I know which commit you are cherry-picking and its linked automatically in the commit message.
was this a clean cherry-pick or did you have conflicts?

[tssurya]

/lgtm
same as b2bfdf1

[tssurya]

/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jluhrsen, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tssurya]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jluhrsen]

@jluhrsen : did you cherry-pick this? we usually preserve history which means you must cherry-pick b2bfdf1 with the -x option so that I know which commit you are cherry-picking and its linked automatically in the commit message. was this a clean cherry-pick or did you have conflicts?

I didn't use the -x option I guess. The original 4.15 commit came in with a d/s merge so I
couldn't use the GH bot to cherry pick it. But, yes it was a clean one. Sorry for the confusion.

[mffiedler]

/label cherry-pick-approved

[openshift-ci-robot]

@jluhrsen: Jira Issue OCPBUGS-27925: All pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#2026

Jira Issue OCPBUGS-27925 has been moved to the MODIFIED state.

In response to this:

in some cases, multiple nodes will have to sync and we may not have enough subnets available for all of them. In that case we don't want to quit the sync on other nodes if one is found to not have the subnet annotation as the others may still have it.

Also moves log message for duration of different syncs to the end of their sync so it will only print once.

JIRA: https://issues.redhat.com/browse/OCPBUGS-18598

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.14.0-202402060410.p0.g91bcb7b.assembly.stream for distgit ovn-kubernetes-base.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2024-02-06-070712

[openshift-merge-robot]

Fix included in accepted release 4.14.0-0.nightly-2024-05-30-083125