OCPBUGS-33294: Reuse node-subnet from cache if exists

[arghosh93]

This PR is to return an already allocated subnet instead of creating a new one if a combination of subnet and node name already exists in the cache.

This PR is to stop multiple allocation of node-subnet from ClusterNetwork CIDR for any node if addition of
'k8s.ovn.org/node-subnets' annotation gets delayed but does not reach default BackOff[1] time limit for retry framework and meanwhile syncNodeNetworkAnnotations[2] gets executed multiple times.

JIRA: https://issues.redhat.com/browse/OCPBUGS-25733
[1] - https://github.com/kubernetes/client-go/blob/v0.26.1/util/retry/util.go#L38
[2] - https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/clustermanager/node/node_allocator.go#L178

Signed-off-by: Arnab Ghosh arnabghosh89@gmail.com
(cherry picked from commit afe0b64)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-33294, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected Jira Issue OCPBUGS-33294 to depend on a bug targeting a version in 4.16.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is to return an already allocated subnet instead of creating a new one if a combination of subnet and node name already exists in the cache.

This PR is to stop multiple allocation of node-subnet from ClusterNetwork CIDR for any node if addition of
'k8s.ovn.org/node-subnets' annotation gets delayed but does not reach default BackOff[1] time limit for retry framework and meanwhile syncNodeNetworkAnnotations[2] gets executed multiple times.

JIRA: https://issues.redhat.com/browse/OCPBUGS-25733
[1] - https://github.com/kubernetes/client-go/blob/v0.26.1/util/retry/util.go#L38
[2] - https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/clustermanager/node/node_allocator.go#L178

Signed-off-by: Arnab Ghosh arnabghosh89@gmail.com
(cherry picked from commit afe0b64)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @arghosh93. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pperiyasamy]

/jira refresh

[openshift-ci-robot]

@pperiyasamy: This pull request references Jira Issue OCPBUGS-33294, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-25733 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Cannot Reproduce) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pperiyasamy]

/ok-to-test

[arghosh93]

/retest-required

[arghosh93]

/retest-required

[tssurya]

/jira refresh

[openshift-ci-robot]

@tssurya: This pull request references Jira Issue OCPBUGS-33294, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-25733 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[tssurya]

/lgtm
/approve
/label bacport-risk-assessed

[tssurya]

/label backport-risk-assessed

[openshift-ci]

@tssurya: The label(s) /label bacport-risk-assessed cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/lgtm
/approve
/label bacport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tssurya]

/retest-required

[jechen0648]

/label cherry-pick-approved

[abhat]

/cherry-pick release-4.14

[openshift-cherrypick-robot]

@abhat: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[arghosh93]

/retest-required

[abhat]

/jira refresh

[openshift-ci-robot]

@abhat: This pull request references Jira Issue OCPBUGS-33294, which is invalid:

• expected dependent Jira Issue OCPBUGS-25733 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[abhat]

/jira cherry-pick release-4.14

[abhat]

/jira cherrypick OCPBUGS-33294

[openshift-ci-robot]

@abhat: Jira Issue OCPBUGS-33294 has been cloned as Jira Issue OCPBUGS-34076. Will retitle bug to link to clone.
/retitle OCPBUGS-34076: OCPBUGS-33294: Reuse node-subnet from cache if exists

In response to this:

/jira cherrypick OCPBUGS-33294

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-34076, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
• expected dependent Jira Issue OCPBUGS-33294 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead
• expected dependent Jira Issue OCPBUGS-33294 to target a version in 4.16.0, but it targets "4.15.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is to return an already allocated subnet instead of creating a new one if a combination of subnet and node name already exists in the cache.

This PR is to stop multiple allocation of node-subnet from ClusterNetwork CIDR for any node if addition of
'k8s.ovn.org/node-subnets' annotation gets delayed but does not reach default BackOff[1] time limit for retry framework and meanwhile syncNodeNetworkAnnotations[2] gets executed multiple times.

JIRA: https://issues.redhat.com/browse/OCPBUGS-25733
[1] - https://github.com/kubernetes/client-go/blob/v0.26.1/util/retry/util.go#L38
[2] - https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/clustermanager/node/node_allocator.go#L178

Signed-off-by: Arnab Ghosh arnabghosh89@gmail.com
(cherry picked from commit afe0b64)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[abhat]

/retitle OCPBUGS-33294: Reuse node-subnet from cache if exists

[openshift-ci-robot]

@arghosh93: This pull request references Jira Issue OCPBUGS-33294, which is invalid:

• expected dependent Jira Issue OCPBUGS-25733 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

This PR is to return an already allocated subnet instead of creating a new one if a combination of subnet and node name already exists in the cache.

This PR is to stop multiple allocation of node-subnet from ClusterNetwork CIDR for any node if addition of
'k8s.ovn.org/node-subnets' annotation gets delayed but does not reach default BackOff[1] time limit for retry framework and meanwhile syncNodeNetworkAnnotations[2] gets executed multiple times.

JIRA: https://issues.redhat.com/browse/OCPBUGS-25733
[1] - https://github.com/kubernetes/client-go/blob/v0.26.1/util/retry/util.go#L38
[2] - https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/clustermanager/node/node_allocator.go#L178

Signed-off-by: Arnab Ghosh arnabghosh89@gmail.com
(cherry picked from commit afe0b64)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[abhat]

/jira refresh

[openshift-ci-robot]

@abhat: This pull request references Jira Issue OCPBUGS-33294, which is valid.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.z) matches configured target version for branch (4.15.z)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-25733 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-25733 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
• bug has dependents

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@arghosh93: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	73bdfc9	link	false	/test security
ci/prow/e2e-aws-ovn-kubevirt	73bdfc9	link	false	/test e2e-aws-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[arghosh93]

/retest-required

[openshift-ci-robot]

@arghosh93: Jira Issue OCPBUGS-33294: All pull requests linked via external trackers have merged:

• openshift/ovn-kubernetes#2163

Jira Issue OCPBUGS-33294 has been moved to the MODIFIED state.

In response to this:

This PR is to return an already allocated subnet instead of creating a new one if a combination of subnet and node name already exists in the cache.

This PR is to stop multiple allocation of node-subnet from ClusterNetwork CIDR for any node if addition of
'k8s.ovn.org/node-subnets' annotation gets delayed but does not reach default BackOff[1] time limit for retry framework and meanwhile syncNodeNetworkAnnotations[2] gets executed multiple times.

JIRA: https://issues.redhat.com/browse/OCPBUGS-25733
[1] - https://github.com/kubernetes/client-go/blob/v0.26.1/util/retry/util.go#L38
[2] - https://github.com/ovn-org/ovn-kubernetes/blob/master/go-controller/pkg/clustermanager/node/node_allocator.go#L178

Signed-off-by: Arnab Ghosh arnabghosh89@gmail.com
(cherry picked from commit afe0b64)

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@abhat: new pull request created: #2177

In response to this:

/cherry-pick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ovn-kubernetes-base-container-v4.15.0-202405221005.p0.g25a771d.assembly.stream.el9 for distgit ovn-kubernetes-base.
All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-05-22-165653