OCPBUGS-38267,OCPBUGS-38653: EgressIP VRF support & stale EgressIP LRP when node deleted #2263
Conversation
Signed-off-by: Martin Kennelly <mkennell@redhat.com> (cherry picked from commit fb0d5ca)
Signed-off-by: Martin Kennelly <mkennell@redhat.com> (cherry picked from commit 86ab926)
Signed-off-by: Martin Kennelly <mkennell@redhat.com> (cherry picked from commit 2f0d03b)
Add test cases to cover this scenario. Signed-off-by: Martin Kennelly <mkennell@redhat.com> (cherry picked from commit df2da15)
The EgressIP assigned node is accidently deleted from cluster which causes EIP is moved to another node, but while updating nexthops EgressIP zone controller is not able to find node object to remove nexthop from Logical Route Policy for the old node and this becomes a stale entry on the LRP. This commit ensures nexthop is updated even when node is not found from the watch factory. Signed-off-by: Periyasamy Palanisamy <pepalani@redhat.com> (cherry picked from commit 52317f1)
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci-robot
added
jira/severity-important
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-38267, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. This pull request references Jira Issue OCPBUGS-38653, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
@martinkennelly: GitHub didn't allow me to request PR reviews from the following users: martinkennelly. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-38267. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. This pull request references Jira Issue OCPBUGS-38653. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: martinkennelly The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Depends on #2259
/hold
/cc