Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1906986: 12-11-20 merge #384

Merged
merged 11 commits into from Dec 12, 2020

Conversation

trozet
Copy link
Contributor

@trozet trozet commented Dec 12, 2020

Includes CNI check and fix for retrying failed pod adds

roytman and others added 11 commits December 9, 2020 12:07
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
Signed-off-by: Alexey Roytman <roytman@il.ibm.com>
Signed-off-by: Dan Williams <dcbw@redhat.com>
shared-gateway: ignore empty Ingress IPs
Signed-off-by: Tim Rozet <trozet@redhat.com>
Add support to the CNI CHECK command
If a pod add fails in ovnkube-master, and there is no subsequent update
event for the pod we never try to add it again and CNI will just
continuously fail. A prime example of this is if a pod is added for a
node, who has not yet registered with ovnkube-master by setting its L3
gateway config.

This patch adds a goroutine which will run and check to see if there are
any pods that need retry who have been sitting for longer than a minute.
If such pods exist, the goroutine will attempt to addLogicalPort for
them.

Signed-off-by: Tim Rozet <trozet@redhat.com>
Co-Authored-by: Dan Williams <dcbw@redhat.com>
Adds reconciliation for hanging pod adds
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2020
@trozet
Copy link
Contributor Author

trozet commented Dec 12, 2020

@dcbw @danwinship

@dcbw
Copy link
Contributor

dcbw commented Dec 12, 2020

/retest
only aws failure is [sig-api-machinery][Feature:APIServer][Late] kube-apiserver terminates within graceful termination period [Suite:openshift/conformance/parallel]

@dcbw
Copy link
Contributor

dcbw commented Dec 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcbw dcbw changed the title 12-11-20 merge Bug 1906986: 12-11-20 merge Dec 12, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 12, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: This pull request references Bugzilla bug 1906986, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906986: 12-11-20 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor

dcbw commented Dec 12, 2020

vsphere failures are mostly variations of:

error: unable to read image docker.io/library/mysql:latest: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit

@dcbw
Copy link
Contributor

dcbw commented Dec 12, 2020

vsphere has docker pull issues still, windows has known failures, and openstack failed terraform.
/retest

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Dec 12, 2020

@trozet: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn d7d0b75 link /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn d7d0b75 link /test e2e-openstack-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit ae82858 into openshift:master Dec 12, 2020
@openshift-ci-robot
Copy link
Contributor

@trozet: All pull requests linked via external trackers have merged:

Bugzilla bug 1906986 has been moved to the MODIFIED state.

In response to this:

Bug 1906986: 12-11-20 merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants