Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile: remove unecessary --enablerepo #60

Merged
merged 1 commit into from Nov 14, 2019
Merged

Dockerfile: remove unecessary --enablerepo #60

merged 1 commit into from Nov 14, 2019

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Nov 13, 2019 •
edited

Turns out we don't need to --enablerepo for yumdownloader; the repo is already enabled.

@jupierce @wking @squeed @gmarkley-VI

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 13, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2019
@dcbw
Dockerfile: remove unecessary --enablerepo
8252811 
Turns out we don't need to --enablerepo for yumdownloader; the repo
is already enabled.
@dcbw dcbw changed the title asdfasf Dockerfile: remove unecessary --enablerepo Nov 13, 2019
@dcbw
Copy link
Contributor Author

dcbw commented Nov 13, 2019

/test e2e-aws-ovn-kubernetes

@sosiouxme
Copy link
Member

/lgtm
(FWIW)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@sosiouxme
Copy link
Member

/retest

pecameron
pecameron reviewed Nov 13, 2019
View reviewed changes
Copy link
Contributor

@pecameron pecameron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, pecameron, sosiouxme

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcbw
Copy link
Contributor Author

dcbw commented Nov 13, 2019

/test e2e-aws-ovn-kubernetes

@dcbw
Copy link
Contributor Author

dcbw commented Nov 13, 2019

e2e test failures may be fixed by ovn-org/ovn-kubernetes#927

@dcbw
Copy link
Contributor Author

dcbw commented Nov 14, 2019

This is blocking on openshift/origin#24147

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@danwinship
Copy link
Contributor

/hold
to stop the bot, feel free to cancel when the tests are fixed

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@dcbw
Copy link
Contributor Author

dcbw commented Nov 14, 2019

/retest

@dcbw
Copy link
Contributor Author

dcbw commented Nov 14, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link
Contributor

@dcbw: /override requires a failed status context to operate on.
The following unknown contexts were given:

  • e2e-aws-ovn-kubernetes

Only the following contexts were expected:

  • ci/prow/e2e-aws-ovn-kubernetes
  • ci/prow/images
  • tide

In response to this:

/override e2e-aws-ovn-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Nov 14, 2019

/override ci/prow/e2e-aws-ovn-kubernetes

@openshift-ci-robot
Copy link
Contributor

@dcbw: Overrode contexts on behalf of dcbw: ci/prow/e2e-aws-ovn-kubernetes

In response to this:

/override ci/prow/e2e-aws-ovn-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Nov 14, 2019

/refresh

@openshift-merge-robot openshift-merge-robot merged commit 6a7ba6b into openshift:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pecameron pecameron pecameron left review comments

@alexanderConstantinescu alexanderConstantinescu Awaiting requested review from alexanderConstantinescu

@squeed squeed Awaiting requested review from squeed

Assignees

@sosiouxme sosiouxme

@pecameron pecameron

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dcbw @sosiouxme @openshift-ci-robot @openshift-bot @danwinship @pecameron @openshift-merge-robot