Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1999852: bump OVN to ovn21.09-21.09.0-18.el8fdp #704

Merged

Conversation

dcbw
Copy link
Contributor

@dcbw dcbw commented Aug 31, 2021

Includes fixes for:

  • optimizations to loadbalancer logical flow creation in northd (reduced latency and iteration time)
  • optimized hashing in northd (reduced latency and iteration time)
  • additional northd stopwatches for debugging iteration times
  • two northd perf optimizations to avoid multiple identical datapath groups
  • optimization to JSON serialization improving all inter-component communication

@openshift-ci openshift-ci bot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@dcbw: This pull request references Bugzilla bug 1999852, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

Bug 1999852: bump OVN to ovn21.09-21.09.0-16.el8fdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 31, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 31, 2021

@dcbw: An error was encountered querying GitHub for users with public email (anusaxen@redhat.com) for bug 1999852 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1999852: bump OVN to ovn21.09-21.09.0-16.el8fdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2021
@dcbw
Copy link
Contributor Author

dcbw commented Aug 31, 2021

/retest

5 similar comments
@dcbw
Copy link
Contributor Author

dcbw commented Sep 1, 2021

/retest

@dcbw
Copy link
Contributor Author

dcbw commented Sep 1, 2021

/retest

@dcbw
Copy link
Contributor Author

dcbw commented Sep 1, 2021

/retest

@dcbw
Copy link
Contributor Author

dcbw commented Sep 1, 2021

/retest

@dcbw
Copy link
Contributor Author

dcbw commented Sep 1, 2021

/retest

@trozet
Copy link
Contributor

trozet commented Sep 1, 2021

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2021
@trozet
Copy link
Contributor

trozet commented Sep 1, 2021

we do not want the revert for zero snat @flavio-fernandes

@trozet
Copy link
Contributor

trozet commented Sep 1, 2021

@dceara FYI

@flavio-fernandes
Copy link
Contributor

we do not want the revert for zero snat @flavio-fernandes

Correct. Let's undo the (partially?)
ovn-org/ovn@82e2415 change in u/s ovn and not use this tag. @putnopvut agree?

@dceara
Copy link
Contributor

dceara commented Sep 1, 2021

we do not want the revert for zero snat @flavio-fernandes

Correct. Let's undo the (partially?)
ovn-org/ovn@82e2415 change in u/s ovn and not use this tag. @putnopvut agree?

@flavio-fernandes I'm not sure it's that straightforward. We need to see how to do it without reintroducing https://bugzilla.redhat.com/show_bug.cgi?id=1992705 I'll try to prepare an u/s OVN patch soon.

@dceara
Copy link
Contributor

dceara commented Sep 1, 2021

@numansiddique FYI

@dceara
Copy link
Contributor

dceara commented Sep 1, 2021

@numansiddique @flavio-fernandes @trozet @putnopvut FYI series to reintroduce all-zero SNAT.

@flavio-fernandes
Copy link
Contributor

@dcbw dcbw changed the title Bug 1999852: bump OVN to ovn21.09-21.09.0-16.el8fdp Bug 1999852: bump OVN to ovn21.09-21.09.0-17.el8fdp Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@dcbw: This pull request references Bugzilla bug 1999852, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dbrahane@redhat.com), skipping review request.

In response to this:

Bug 1999852: bump OVN to ovn21.09-21.09.0-17.el8fdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -33,7 +33,7 @@ RUN yum install -y \
yum clean all

ARG ovsver=2.15.0-28.el8fdp
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcbw won't we also need a new OVS to satisfy the call to the recently introduced 'ovsrec_server_has_datapath_table' symbol?

Ref: https://patchwork.ozlabs.org/project/ovn/patch/20210901191304.532.97471.stgit@dceara.remote.csb/

Copy link
Contributor

@dceara dceara Sep 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavio-fernandes Not really, that's just at compile time and the OVN rpm was built with the correct OVS libs. OVN links statically with OVS libs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. TY. Learning something new every day! ;)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to do that?
i do like this ./configure --with-ovs-source=/root/ovs/openvswitch-2.16.0 --with-ovs-build= /root/ovs/openvswitch-2.6.0
but still has error: undefined reference ""ovsrec_server_has_datapath_table

Includes fixes for:
    optimizations to loadbalancer logical flow creation in northd (reduced latency and iteration time)
    optimized hashing in northd (reduced latency and iteration time)
    additional northd stopwatches for debugging iteration times
    two northd perf optimizations to avoid multiple identical datapath groups
    optimization to JSON serialization improving all inter-component communication
@trozet
Copy link
Contributor

trozet commented Sep 2, 2021

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 2, 2021
@dcbw dcbw changed the title Bug 1999852: bump OVN to ovn21.09-21.09.0-17.el8fdp Bug 1999852: bump OVN to ovn21.09-21.09.0-18.el8fdp Sep 2, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 2, 2021

@dcbw: This pull request references Bugzilla bug 1999852, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (dbrahane@redhat.com), skipping review request.

In response to this:

Bug 1999852: bump OVN to ovn21.09-21.09.0-18.el8fdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Sep 2, 2021

/retest

3 similar comments
@dcbw
Copy link
Contributor Author

dcbw commented Sep 2, 2021

/retest

@dcbw
Copy link
Contributor Author

dcbw commented Sep 3, 2021

/retest

@dcbw
Copy link
Contributor Author

dcbw commented Sep 3, 2021

/retest

@abhat
Copy link
Contributor

abhat commented Sep 3, 2021

/override ci/prow/e2e-gcp-ovn
Fails because of: https://bugzilla.redhat.com/show_bug.cgi?id=2000589

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

@abhat: Overrode contexts on behalf of abhat: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn
Fails because of: https://bugzilla.redhat.com/show_bug.cgi?id=2000589

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dcbw
Copy link
Contributor Author

dcbw commented Sep 3, 2021

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

@dcbw: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-vsphere-ovn 8bda565 link /test e2e-vsphere-ovn
ci/prow/e2e-openstack-ovn 8bda565 link /test e2e-openstack-ovn
ci/prow/okd-e2e-gcp-ovn 8bda565 link /test okd-e2e-gcp-ovn
ci/prow/e2e-azure-ovn 8bda565 link /test e2e-azure-ovn
ci/prow/e2e-vsphere-windows 8bda565 link /test e2e-vsphere-windows

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mccv1r0
Copy link
Contributor

mccv1r0 commented Sep 3, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, mccv1r0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 300ed96 into openshift:master Sep 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2021

@dcbw: All pull requests linked via external trackers have merged:

Bugzilla bug 1999852 has been moved to the MODIFIED state.

In response to this:

Bug 1999852: bump OVN to ovn21.09-21.09.0-18.el8fdp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants