Bug 2011386: pods: fix overwriting returned error from defer() #787
Conversation
dcbw
changed the title
openshift-ci
bot
added
approved
|
@dcbw: This pull request references Bugzilla bug 2011386, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dcbw
force-pushed
the
pod-error-overwrite
branch
from
bfb41da
to
e97ffe4
Compare
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@dcbw: This pull request references Bugzilla bug 2011386, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
Using the same error variable name in the defer() overwrote the error itself, and caused the function to return nil even though an error had occurred. Fixes: 35dd1ae CARRY: run all pod deletion OVN commands as a batch
dcbw
force-pushed
the
pod-error-overwrite
branch
from
e97ffe4
to
0505367
Compare
|
/hold cancel |
| err = oc.ovnNBClient.Execute(addrSetCmds...) | ||
| if err != nil { | ||
| klog.Errorf("Error removing pod %s IPs from namespace address set: %v", portName, err) | ||
| if addrErr := oc.ovnNBClient.Execute(addrSetCmds...); addrErr != nil { |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dcbw, trozet, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@dcbw: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@dcbw: All pull requests linked via external trackers have merged: Bugzilla bug 2011386 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Using the same error variable name in the defer() overwrote
the error itself, and caused the function to return nil even
though an error had occurred.
This is only an issue downstream as the problem code only exists downstream as a CARRY.
@trozet