[WIP] Scale fixes - only LBG #814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: handle case when LBG are not supported by OVN. Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Allow up to 1k pods per node. Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
Signed-off-by: Dumitru Ceara <dceara@redhat.com>
…builds). By default log DB transactions for LSP and Port_Binding. In ovn-controller log iface-id-ver mismatches. Signed-off-by: Dumitru Ceara <dceara@redhat.com>
This includes ovsdb-idl changes from: dceara/ovs@0414012 Signed-off-by: Dumitru Ceara <dceara@redhat.com>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dceara The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If a single routeInfo had multiple external routes that matched the same gateway IP, that routeInfo could be added to the returned list multiple times. It was only locked once, however. But deletePodGWRoutesForNamespace() iterates over the list returned by getRouteInfosForGateway() and calls Unlock() on each element in the list, which can create an unbalanced locking situation (multiple Unlocks for a single Lock) in the above situation where a routeInfo has multiple external routes matching the same gatewayIP. Signed-off-by: Dan Williams <dcbw@redhat.com>
At least give a clue what's wrong instead of just: "failed: exit status 1"
When deciding if a service needs updating, we do a reflect.DeepEqual on the existing load balancers that are stored in a cache, vs the load balancers that would be built by the operation. This comparison was incorrect, because it was comparing the UUID field, which will never be equal. The end result is potentially a lot more pressure on OVN for transactions that essentially do nothing. Signed-off-by: Tim Rozet <trozet@redhat.com>
There's no point in limiting the timeout to something lower than the CRI timeout; it just causes pods in large-scale clusters to hit the kubelet retry backoffs and take even longer to bring up. Continued improvements to OVN will reduce the need for longer timeouts in the near future. Signed-off-by: Dan Williams <dcbw@redhat.com>
This picks up OVN fix for setting lrp gw chassis: ovn-org/ovn@e6bcb88 Signed-off-by: Dumitru Ceara <dceara@redhat.com>
dceara
force-pushed
the
scale-fixes-lbg
branch
from
6855b4f
to
56b9506
Compare
|
/test images |
2 similar comments
|
/test images |
|
/test images |
|
/retest |
Cherry-picked from: ovn-org/ovn-kubernetes@f18feab Signed-off-by: Dan Williams <dcbw@redhat.com>
dceara
force-pushed
the
scale-fixes-lbg
branch
from
7586517
to
d8b7b0b
Compare
|
@dceara: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-rebase
|
@dceara: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Closed
|
Latest WIP scale testing PR: #839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc: @tssurya