Bug 2059354: [4.10z] After reboot egress node, lr-policy-list was not correct #994

flavio-fernandes · 2022-03-11T18:58:37Z

In cases where OVN database for logical router policies or NATs
used by EgressIPs have stale nexthops or wrong external_ips, the
sync function should remove them, so the proper row/column gets set.

In order to cleanly apply these changes from 4.11, the following commits were also added:

[DownstreamMerge] Downstream merge 2-1-22 #940 (pulled in upstream Make sync failures fatal after retries ovn-org/ovn-kubernetes#2773)
Bug 2011525: [DownstreamMerge] Downstream merge 08-02-2022 #947 (pulled in upstream Fix cache building used for removing stale egress IPs ovn-org/ovn-kubernetes#2783)

Signed-off-by: Flavio Fernandes flaviof@redhat.com

openshift-ci · 2022-03-11T18:58:39Z

@flavio-fernandes: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Bug 2059354 [4.10]: TRIVIAL Enable info logging for successful assignment of egress IP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-11T19:02:25Z

@flavio-fernandes: This pull request references Bugzilla bug 2059354, which is invalid:

expected the bug to target the "4.10.z" release, but it targets "4.10.0" instead
expected Bugzilla bug 2059354 to depend on a bug targeting a release in 4.11.0 and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2059354: [4.10] TRIVIAL Enable info logging for successful assignment of egress IP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flavio-fernandes · 2022-03-11T19:12:48Z

/bugzilla refresh

openshift-ci · 2022-03-11T19:12:52Z

@flavio-fernandes: This pull request references Bugzilla bug 2059354, which is invalid:

expected dependent Bugzilla bug 2063321 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

flavio-fernandes · 2022-03-11T19:28:42Z

/assign @trozet

openshift-ci · 2022-03-16T21:45:43Z

@flavio-fernandes: This pull request references Bugzilla bug 2059354, which is invalid:

expected dependent Bugzilla bug 2063321 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2059354: [4.10z] After reboot egress node, lr-policy-list was not correct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dougsland · 2022-03-21T19:05:18Z

/retest

flavio-fernandes · 2022-03-22T15:06:36Z

/bugzilla refresh

openshift-ci · 2022-03-22T15:06:40Z

@flavio-fernandes: This pull request references Bugzilla bug 2059354, which is invalid:

expected dependent Bugzilla bug 2063321 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trozet · 2022-03-23T13:53:03Z

/lgtm
/label backport-risk-assessed

flavio-fernandes · 2022-03-23T14:13:07Z

/test e2e-gcp-ovn

openshift-bot · 2022-03-23T14:42:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-24T01:00:57Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci · 2022-03-24T01:01:01Z

@openshift-bot: This pull request references Bugzilla bug 2059354, which is invalid:

expected dependent Bugzilla bug 2063321 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jechen0648 · 2022-03-24T02:40:26Z

/bugzilla cc-qa

openshift-ci · 2022-03-24T02:40:30Z

@jechen0648: This pull request references Bugzilla bug 2059354, which is invalid:

expected dependent Bugzilla bug 2063321 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jechen0648 · 2022-03-24T02:41:23Z

/label qe-approved

This brings in options for ACLs required for ACL egress pipeline to apply after load balancing. Since there is no comparable ovn image for fc34, this change also bumps the fedora base image to 35. Signed-off-by: Flavio Fernandes <flaviof@redhat.com>

trozet · 2022-03-30T19:49:10Z

/lgtm

openshift-ci · 2022-03-30T19:49:47Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, JacobTanenbaum, trozet, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [JacobTanenbaum,trozet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2022-03-30T20:28:47Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T22:23:58Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-30T22:36:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

flavio-fernandes · 2022-03-30T23:00:44Z

/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-local-gateway

openshift-bot · 2022-03-31T01:27:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T02:44:55Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T03:23:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T04:41:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T04:54:57Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T06:39:51Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T08:09:56Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T11:08:27Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T11:47:30Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2022-03-31T12:52:28Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2022-03-31T14:20:51Z

@flavio-fernandes: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	`bf5f2fb`	link	true	`/test e2e-metal-ipi-ovn-ipv6`
ci/prow/e2e-vsphere-windows	`bf5f2fb`	link	false	`/test e2e-vsphere-windows`
ci/prow/okd-e2e-gcp-ovn	`bf5f2fb`	link	false	`/test okd-e2e-gcp-ovn`
ci/prow/e2e-vsphere-ovn	`bf5f2fb`	link	false	`/test e2e-vsphere-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

flavio-fernandes · 2022-03-31T14:30:36Z

/test e2e-metal-ipi-ovn-ipv6

openshift-bot · 2022-03-31T14:37:53Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

flavio-fernandes · 2022-03-31T15:37:38Z

@trozet this PR passed the failing job ( e2e-metal-ipi-ovn-ipv6 ) before, so I would like to request an override, if you would be okay with that.

trozet · 2022-03-31T17:23:43Z

ipv6 is broken due to: https://bugzilla.redhat.com/show_bug.cgi?id=2070703

/override ci/prow/e2e-metal-ipi-ovn-ipv6

openshift-ci · 2022-03-31T17:24:16Z

@trozet: Overrode contexts on behalf of trozet: ci/prow/e2e-metal-ipi-ovn-ipv6

In response to this:

ipv6 is broken due to: https://bugzilla.redhat.com/show_bug.cgi?id=2070703

/override ci/prow/e2e-metal-ipi-ovn-ipv6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2022-03-31T17:24:47Z

@flavio-fernandes: All pull requests linked via external trackers have merged:

openshift/ovn-kubernetes#994

Bugzilla bug 2059354 has been moved to the MODIFIED state.

In response to this:

Bug 2059354: [4.10z] After reboot egress node, lr-policy-list was not correct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from squeed and tssurya March 11, 2022 18:59

flavio-fernandes changed the title ~~Bug 2059354 [4.10]: TRIVIAL Enable info logging for successful assignment of egress IP~~ Bug 2059354: [4.10] TRIVIAL Enable info logging for successful assignment of egress IP Mar 11, 2022

openshift-ci bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 11, 2022

flavio-fernandes changed the title ~~Bug 2059354: [4.10] TRIVIAL Enable info logging for successful assignment of egress IP~~ Bug 2059354: [4.10z] TRIVIAL Enable info logging for successful assignment of egress IP Mar 11, 2022

openshift-ci bot assigned trozet Mar 11, 2022

flavio-fernandes force-pushed the bz2059354_4.10 branch from 7065151 to 245bdaa Compare March 16, 2022 21:25

flavio-fernandes changed the title ~~Bug 2059354: [4.10z] TRIVIAL Enable info logging for successful assignment of egress IP~~ Bug 2059354: [4.10z] After reboot egress node, lr-policy-list was not correct Mar 16, 2022

flavio-fernandes mentioned this pull request Mar 16, 2022

Bug 2059700: [4.9z] After reboot egress node, lr-policy-list was not correct, some duplicate records or missed internal IPs #981

Merged

openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 23, 2022

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2022

openshift-merge-robot merged commit c580607 into openshift:release-4.10 Mar 31, 2022

flavio-fernandes deleted the bz2059354_4.10 branch March 31, 2022 18:43

flavio-fernandes mentioned this pull request Apr 6, 2022

Bug 2062842: [4.8z] After reboot egress node, lr-policy-list was not correct, some duplicate records or missed internal IPs #1009

Merged

openshift-ci bot mentioned this pull request Apr 22, 2022

[release-4.10] Bug 2052017: Retry Pod Deletions on Failure #1025

Merged

Bug 2059354: [4.10z] After reboot egress node, lr-policy-list was not correct #994

Bug 2059354: [4.10z] After reboot egress node, lr-policy-list was not correct #994

Conversation

flavio-fernandes commented Mar 11, 2022 • edited Loading

openshift-ci bot commented Mar 11, 2022

openshift-ci bot commented Mar 11, 2022

flavio-fernandes commented Mar 11, 2022

openshift-ci bot commented Mar 11, 2022

flavio-fernandes commented Mar 11, 2022

openshift-ci bot commented Mar 16, 2022

dougsland commented Mar 21, 2022

flavio-fernandes commented Mar 22, 2022

openshift-ci bot commented Mar 22, 2022

trozet commented Mar 23, 2022

flavio-fernandes commented Mar 23, 2022

openshift-bot commented Mar 23, 2022

openshift-bot commented Mar 24, 2022

openshift-ci bot commented Mar 24, 2022

jechen0648 commented Mar 24, 2022

openshift-ci bot commented Mar 24, 2022

jechen0648 commented Mar 24, 2022

trozet commented Mar 30, 2022

openshift-ci bot commented Mar 30, 2022

openshift-bot commented Mar 30, 2022

openshift-bot commented Mar 30, 2022

openshift-bot commented Mar 30, 2022

flavio-fernandes commented Mar 30, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

openshift-ci bot commented Mar 31, 2022

flavio-fernandes commented Mar 31, 2022

openshift-bot commented Mar 31, 2022

flavio-fernandes commented Mar 31, 2022

trozet commented Mar 31, 2022

openshift-ci bot commented Mar 31, 2022

openshift-ci bot commented Mar 31, 2022

flavio-fernandes commented Mar 11, 2022 •

edited

Loading