Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-21757: switch to bingo for dependency management (and bump golangci-lint@v1.51.0) #95

Merged
merged 2 commits into from Oct 16, 2023

Conversation

joelanford
Copy link
Member

No description provided.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2023
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2023
Signed-off-by: Joe Lanford <joe.lanford@gmail.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2023
@joelanford joelanford changed the title switch to bingo for dependency management switch to bingo for dependency management (and bump golangci-lint@v1.51.0) Oct 16, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelanford, ncdc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9dae247 and 2 for PR HEAD d62f1cd in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2023

@joelanford: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 8d050ee into openshift:main Oct 16, 2023
6 checks passed
@joelanford
Copy link
Member Author

/cherrypick release-4.14

@joelanford
Copy link
Member Author

I retroactively created https://issues.redhat.com/browse/OCPBUGS-21757 for this bug.

@joelanford joelanford changed the title switch to bingo for dependency management (and bump golangci-lint@v1.51.0) OCPBUGS-21757: switch to bingo for dependency management (and bump golangci-lint@v1.51.0) Oct 16, 2023
@openshift-ci-robot
Copy link

@joelanford: Jira Issue OCPBUGS-21757 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@joelanford: new pull request created: #98

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking added a commit to wking/platform-operators that referenced this pull request Oct 26, 2023
3dd23a9 (Makefile,manifests: Remove the PlatformOperators cluster
profile hacks, 2022-09-21, openshift#64) removed the final consumer.
Subsequently 39662d6 (switch to bingo for dependency management,
2023-10-13, openshift#95) removed some other related targets and the YQ
variable definition.  But this manifests prereq snuck through, until
this commit, where I'm removing it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants