OLM-2763: Remove the PlatformOperators CRD cluster profile hacks #64
Conversation
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
This is a no-op so adding the requisite labels. /label px-approved |
openshift-ci
bot
added
px-approved
timflannagan
changed the title
| @@ -18,100 +18,143 @@ spec: | |||
| singular: platformoperator | |||
| scope: Cluster | |||
| versions: | |||
| - name: v1alpha1 | |||
There was a problem hiding this comment.
Note: This is just due to identification diff between the last recorded version of this PlatformOperators CRD manifest. IIRC, the o/api bumped the yq dependency which may explain the indentation diff.
|
@timflannagan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
timflannagan
deleted the
remove-platformoperator-cluster-profile-hacks
branch
3dd23a9 (Makefile,manifests: Remove the PlatformOperators cluster profile hacks, 2022-09-21, openshift#64) removed the final consumer. Subsequently 39662d6 (switch to bingo for dependency management, 2023-10-13, openshift#95) removed some other related targets and the YQ variable definition. But this manifests prereq snuck through, until this commit, where I'm removing it.
Bumps the o/api dependency to pull in the changes in openshift/api#1282, and removes the in-tree Makefile hacks that injected the requisite cluster profile annotations.