Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating golang-github-prometheus-alertmanager builder & base images to be consistent with ART #38

Conversation

jupierce
Copy link

@jupierce jupierce commented Oct 7, 2020

Updating golang-github-prometheus-alertmanager builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/f66c03011773dc3755ad874fc691be612914d65f/images/golang-github-prometheus-alertmanager.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@simonpasquier
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 7, 2020
@jupierce jupierce force-pushed the art-consistency-openshift-4.7-golang-github-prometheus-alertmanager branch from 4a38cab to ceaa2e6 Compare October 7, 2020 15:33
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2020
@jupierce jupierce force-pushed the art-consistency-openshift-4.7-golang-github-prometheus-alertmanager branch from ceaa2e6 to 209002d Compare October 7, 2020 19:50
@simonpasquier
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jupierce, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4cf1c8e into openshift:master Oct 8, 2020
philipgough pushed a commit to philipgough/prometheus-alertmanager that referenced this pull request Feb 19, 2024
* Updated COMPONENT_VERSION file for release-2.8

Signed-off-by: dislbenn <dbennett@redhat.com>

* added COMPONENT_NAME file to repo

Signed-off-by: dislbenn <dbennett@redhat.com>

Signed-off-by: dislbenn <dbennett@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants