Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: Remove limits #24

Merged
merged 1 commit into from
Apr 17, 2019
Merged

*: Remove limits #24

merged 1 commit into from
Apr 17, 2019

Conversation

brancz
Copy link

@brancz brancz commented Apr 16, 2019

This is step 1 of the strategy outlined in https://bugzilla.redhat.com/show_bug.cgi?id=1700051#c2

Unfortunately these are hardcoded into the prometheus-operator as of right now. We're going to go with the following strategy:

* Patch the fork we ship in OpenShift to completely remove the limits.
* Upstream since has added flags to configure these requests/limits, in addition we will add that the 0 value will make the limit/request be removed entirely, and this is what we'll switch to in a future OpenShift version.

@mxinden @squat @s-urbaniak @metalmatze @paulfantom

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 16, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@brancz
Copy link
Author

brancz commented Apr 16, 2019

/retest

1 similar comment
@brancz
Copy link
Author

brancz commented Apr 17, 2019

/retest

metalmatze
metalmatze approved these changes Apr 17, 2019
View reviewed changes
Copy link

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, metalmatze

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 73ed419 into openshift:master Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze approved these changes

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

@squat squat Awaiting requested review from squat

Assignees

@metalmatze metalmatze

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brancz @openshift-ci-robot @metalmatze @openshift-merge-robot