Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-34264: Updating golang-github-prometheus-prometheus-container image to be consistent with ART for 4.17 #205

Conversation

slashpai
Copy link
Member

superseeds #203 (ran go mod vendor on top of it)

@slashpai slashpai changed the title Art consistency openshift 4.17 golang GitHub prometheus prometheus OCPBUGS-34264: Updating golang-github-prometheus-prometheus-container image to be consistent with ART for 4.17 Jun 18, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 18, 2024
@openshift-ci-robot
Copy link

@slashpai: This pull request references Jira Issue OCPBUGS-34264, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

superseeds #203 (ran go mod vendor on top of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jan--f and machine424 June 18, 2024 11:01
Copy link

openshift-ci bot commented Jun 18, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: Tai-RedHat.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@slashpai: This pull request references Jira Issue OCPBUGS-34264, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Tai-RedHat

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

superseeds #203 (ran go mod vendor on top of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
@slashpai
Copy link
Member Author

cc @simonpasquier

@slashpai
Copy link
Member Author

/test e2e-aws-ovn

Copy link

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
Copy link

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonpasquier, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [simonpasquier,slashpai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jun 18, 2024

@slashpai: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5cb9dad into openshift:master Jun 18, 2024
8 checks passed
@openshift-ci-robot
Copy link

@slashpai: Jira Issue OCPBUGS-34264: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34264 has been moved to the MODIFIED state.

In response to this:

superseeds #203 (ran go mod vendor on top of it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build golang-github-prometheus-prometheus-container-v4.17.0-202406181842.p0.g5cb9dad.assembly.stream.el9 for distgit golang-github-prometheus-prometheus.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants