New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1889711: bump Prometheus to v2.22.2 #62
Bug 1889711: bump Prometheus to v2.22.2 #62
Conversation
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
…tions (prometheus#7860) Signed-off-by: Vijay Samuel <vjsamuel@ebay.com>
We're using Prometheus behind a reverse proxy which authenticates everything based on cookies. Without this attribute the cookie is not send with the request for the manifest.json Signed-off-by: Stefan Bueringer <sbueringer@gmail.com>
Signed-off-by: johncming <johncming@yahoo.com>
…t directory (prometheus#7850) * web: Close and exhaust all response bodies in tests Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Remove empty snapshot directory Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Fix lint Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
…metheus#7871) * Update the storage.md to fix typo, and some grammar/format issue Signed-off-by: Luke Chen <showuon@gmail.com>
The documentation referenced "data volume containers", which were superseded by named volume support in Docker several years ago. There were to bind-mounting examples in the docs that are effectively doing the same thing, but the description of the second was somewhat erroneous. Signed-off-by: Lars Kellogg-Stedman <lars@redhat.com>
Signed-off-by: Jaga Santagostino <jagasantagostino@gmail.com>
Signed-off-by: johncming <johncming@yahoo.com>
…ion section (prometheus#7875) Signed-off-by: Luke Chen <showuon@gmail.com>
…s#6477) Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
* Unnecessary go routine spawn. * Remove unnecessary local variable creation. Signed-off-by: iurii <iurii@coins.ph> Co-authored-by: iurii <iurii@coins.ph>
Signed-off-by: johncming <johncming@yahoo.com>
Upgrade to promu 0.6.0. Signed-off-by: Ben Kochie <superq@gmail.com>
…us#7881) This should make the `NewReadClient()` exported outside the `remote` package Signed-off-by: Anand Sanmukhani <asanmukh@redhat.com>
Signed-off-by: Drumil Patel <drumilpatel720@gmail.com>
`promtool update rules` is no longer available after Prometheus 2.5. Document this to avoid confusion such as in prometheus#6988. Signed-off-by: Christian Hoffmann <mail@hoffmann-christian.info>
The collapse all option as suggested in the corresponding issue has been implemented in this PR. Signed-off-by: Deepjyoti Mondal <djmdeveloper060796@gmail.com>
Update `ALERTS` example be more meta-syntactic. Signed-off-by: Justin Walz <justin.walz10@gmail.com>
Signed-off-by: BurtonQin <bobbqqin@gmail.com>
Merge release 2.21 into master
* Fix EQL when using = inside braces. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * EQL => EQLC and ASSIGN => EQL Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com> * Aligned yacc code. Signed-off-by: Harkishen-Singh <harkishensingh@hotmail.com>
The remote read client needs to use the nethttp.Transport wrapper in order for spans to be instrumented properly. Signed-off-by: Chris Marchbanks <csmarchbanks@gmail.com>
* Default to bigger remote_write sends Raise the default MaxSamplesPerSend to amortise the cost of remote calls across more samples. Lower MaxShards to keep the expected max memory usage within reason. Signed-off-by: Bryan Boreham <bryan@weave.works> * Change default Capacity to 2500 To maintain ratio with MaxSamplesPerSend Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
prometheus#7915) Signed-off-by: Xiaochao Dong (@damnever) <dxc.wolf@gmail.com>
Merge release 2.21 in master
Signed-off-by: Luke Chen <showuon@gmail.com>
* web: Remove APIv2 Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Signed-off-by: venkatbvc <chalapathirao@gmail.com>
v2.22.1 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier: This pull request references Bugzilla bug 1889711, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@simonpasquier: This pull request references Bugzilla bug 1889711, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold needs #63 first |
/retest |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Manager.reload takes the mutex that would make it safe, however releases it before the goroutines spawned are finished with it. Thus more explicit locking of scrapePool.Sync/stop/reload is needed. Signed-off-by: Brian Brazil <brian.brazil@robustperception.io>
Signed-off-by: Frederic Branczyk <fbranczyk@gmail.com>
Cut v2.22.2
/hold v2.22.2 is out :) |
v2.22.2 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
@simonpasquier: This pull request references Bugzilla bug 1889711, which is valid. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juzhao, lilic, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@simonpasquier: All pull requests linked via external trackers have merged: Bugzilla bug 1889711 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backport of #61, #63 and #65 .