Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880990: Choose the interfaces between master and slave. #71

Merged
merged 1 commit into from Sep 28, 2020
Merged

Bug 1880990: Choose the interfaces between master and slave. #71

merged 1 commit into from Sep 28, 2020

Conversation

fedepaol
Copy link
Member

In order to make sure ptp tests are reliable, we look for interfaces compatible between slave and master before running the
tests.

@fedepaol fedepaol force-pushed the discoverdevice branch 6 times, most recently from 3f9cfac to c09c455 Compare September 27, 2020 08:58
@mmirecki
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2020
@fedepaol fedepaol changed the title Tests: Choose the interfaces between master and slave. Bug 1880990: Choose the interfaces between master and slave. Sep 27, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 27, 2020
@openshift-ci-robot
Copy link
Contributor

@fedepaol: This pull request references Bugzilla bug 1880990, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1880990: Choose the interfaces between master and slave.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@fedepaol: This pull request references Bugzilla bug 1880990, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fedepaol
Copy link
Member Author

/retest

@fedepaol
Copy link
Member Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 27, 2020
@fedepaol
Copy link
Member Author

/retest

5 similar comments
@fedepaol
Copy link
Member Author

/retest

@fedepaol
Copy link
Member Author

/retest

@fedepaol
Copy link
Member Author

/retest

@fedepaol
Copy link
Member Author

/retest

@fedepaol
Copy link
Member Author

/retest

@fedepaol
Tests: Choose the interfaces between master and slave.
076cb25 
In order to make sure ptp tests are reliable, we look for
interfaces compatible between slave and master before running the
tests.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@mmirecki
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2020
@fedepaol
Copy link
Member Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2020
@openshift-merge-robot openshift-merge-robot merged commit 6644358 into openshift:master Sep 28, 2020
@openshift-ci-robot
Copy link
Contributor

@fedepaol: All pull requests linked via external trackers have merged:

Bugzilla bug 1880990 has been moved to the MODIFIED state.

In response to this:

Bug 1880990: Choose the interfaces between master and slave.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 28, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fepan fepan Awaiting requested review from fepan

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@mmirecki mmirecki

Labels
bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fedepaol @mmirecki @openshift-ci-robot @openshift-merge-robot