Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1880990: Fix the MTU test #353

Merged
merged 1 commit into from Sep 21, 2020
Merged

Bug 1880990: Fix the MTU test #353

merged 1 commit into from Sep 21, 2020

Conversation

SchSeba
Copy link
Contributor

@SchSeba SchSeba commented Sep 21, 2020

This commit changes the interface we use for the MTU test.

Is better not to use the main SDN interface for the MTU test,
because the test change the MTU of the PF to 9000 and packets start
dropping in the other nodes that have MTU set to 1500.

This commit also add the clean method to the beforeSuite function

Signed-off-by: Sebastian Sch sebassch@gmail.com

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2020
@SchSeba SchSeba changed the title Fix the MTU test Bug 1880990: Fix the MTU test Sep 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 21, 2020
@openshift-ci-robot
Copy link
Contributor

@SchSeba: This pull request references Bugzilla bug 1880990, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1880990: Fix the MTU test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fedepaol
fedepaol reviewed Sep 21, 2020
View reviewed changes
test/conformance/tests/sriov_operator.go Outdated
@@ -215,7 +215,12 @@ var _ = Describe("[sriov] operator", func() {
var runningPod *corev1.Pod
Eventually(func() corev1.PodPhase {
runningPod, err = clients.Pods(namespaces.Test).Get(context.Background(), created.Name, metav1.GetOptions{})
Expect(err).ToNot(HaveOccurred())
if err != nil {
Copy link
Member

@fedepaol fedepaol Sep 21, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just replace this if with its body

@SchSeba
Fix the MTU test
e94876a 
This commit change the interface we use for the MTU test.

Is better not to use the main sdn interface for the MTU test,
because the test change the MTU of the PF to 9000 and packets start
dropping in the other nodes that have MTU set to 1500.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>
@fedepaol
Copy link
Member

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fedepaol, SchSeba

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fedepaol
Copy link
Member

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@SchSeba
Copy link
Contributor Author

SchSeba commented Sep 21, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 21, 2020
@openshift-ci-robot
Copy link
Contributor

@SchSeba: This pull request references Bugzilla bug 1880990, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 21, 2020
@SchSeba
Copy link
Contributor Author

SchSeba commented Sep 21, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 21, 2020
@SchSeba
Copy link
Contributor Author

SchSeba commented Sep 21, 2020

validated

Ran 18 of 20 Specs in 1070.905 seconds
SUCCESS! -- 18 Passed | 0 Failed | 0 Pending | 2 Skipped
--- PASS: TestTest (1074.06s)
PASS

@SchSeba
Copy link
Contributor Author

SchSeba commented Sep 21, 2020

/test e2e-aws

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 68b3cbc into openshift:master Sep 21, 2020
@openshift-ci-robot
Copy link
Contributor

@SchSeba: All pull requests linked via external trackers have merged:

Bugzilla bug 1880990 has been moved to the MODIFIED state.

In response to this:

Bug 1880990: Fix the MTU test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Sep 24, 2020
Merged
Merged
Merged
This was referenced Sep 28, 2020
Merged
Merged
Merged
jerpeter1 pushed a commit to jerpeter1/sriov-network-operator that referenced this pull request Mar 7, 2023
@SchSeba
Merge pull request openshift#353 from SchSeba/support_BF2_connectx
c630e3e 
Add support for BF2 in connectX mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedepaol fedepaol fedepaol left review comments

@pliurh pliurh Awaiting requested review from pliurh

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

Assignees

@fedepaol fedepaol

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SchSeba @openshift-ci-robot @fedepaol @openshift-bot @openshift-merge-robot