SREP-1549: Export metrics for GroupPermissions #15
Conversation
Uses the new https://github.com/openshift/operator-custom-metrics (at v0.2.0 presently) to expose two metrics: * `rbac_permissions_operator_cluster_permission` * `rbac_permissions_operator_namespace_permission` Each has labels to indicate the various state of the CR. Signed-off-by: Lisa Seelye <lseelye@redhat.com>
lisa
added
the
do-not-merge/hold
lisa
requested review from
jewzaam,
jharrington22,
fahlmant,
rogbas and
sam-nguyen7
openshift-ci-robot
added
size/L
Signed-off-by: Lisa Seelye <lseelye@redhat.com>
|
/lgtm |
This reverts commit 4ec55a7.
| Name: "rbac_permissions_operator_namespace_permission", | ||
| Help: "Configured permissions in a per-namespace scope", | ||
| }, []string{ | ||
| "group_name", |
There was a problem hiding this comment.
This is a lot of labels. If anyone these change value that's a new permission. Are all of these needed?
There was a problem hiding this comment.
@fahlmant Right now the labels are mapping to the attributes in the CR for the namespace permission. It's possible we find over time they're not all needed, but for now, I think they're needed. That said, I could see removing "state" as it could be seen as redundant.
Signed-off-by: Lisa Seelye <lseelye@redhat.com>
Signed-off-by: Lisa Seelye <lseelye@redhat.com>
|
This PR is on hold for openshift/operator-custom-metrics#18 to be merged and tagged as v2.0.1. |
Signed-off-by: Lisa Seelye <lseelye@redhat.com>
Signed-off-by: Lisa Seelye <lseelye@redhat.com>
Signed-off-by: Lisa Seelye <lseelye@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fahlmant, liamwazherealso, lisa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
lisa
removed
the
do-not-merge/hold
Uses the new https://github.com/openshift/operator-custom-metrics (at v0.2.0 presently) to expose two metrics:
rbac_permissions_operator_cluster_permissionrbac_permissions_operator_namespace_permissionEach has labels to indicate the various state of the CR.
Signed-off-by: Lisa Seelye lseelye@redhat.com