Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an optional e2e-openstack job to openshift/kubernetes #11740

Merged
merged 1 commit into from Sep 23, 2020
Merged

Add an optional e2e-openstack job to openshift/kubernetes #11740

merged 1 commit into from Sep 23, 2020

Conversation

Fedosin
Copy link
Contributor

@Fedosin Fedosin commented Sep 10, 2020

No description provided.

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 10, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 10, 2020

/test generated-dashboards

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 10, 2020

/test pj-rehearse

@pierreprinetti
Copy link
Member

/retest

1 similar comment
@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 11, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 13, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 13, 2020

/test pj-rehearse

6 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 14, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 14, 2020

/test pj-rehearse

@jsafrane
Copy link
Contributor

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 15, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 16, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 17, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 18, 2020

/retest

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 18, 2020

/test pj-rehearse

@iamemilio
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@sttts
Copy link
Contributor

sttts commented Sep 18, 2020

/assign @tnozicka @marun

tnozicka
tnozicka suggested changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be in the config as well. (Unless it changed recently.)
The steps (commits) I'd do:

  1. Add it to the config

    release/ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml

    Line 250 in 612b825

    - as: e2e-vsphere
  2. Run the generator
  3. Add commit with changes on top of the generated code (optional, always run, ...)

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@Fedosin Fedosin force-pushed the kubernetes_e2e_openstack branch 3 times, most recently from 22ef004 to 7ca6bcd Compare September 18, 2020 22:15
@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 19, 2020

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 19, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 21, 2020

/test pj-rehearse

3 similar comments
@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 21, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 21, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 21, 2020

/test pj-rehearse

@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 22, 2020

@tnozicka Unfortunately now there are no registered e2e workflows for OpenStack: https://github.com/openshift/release/tree/master/ci-operator/step-registry/openshift/e2e

Because of this we cannot generate jobs automatically with make jobs command, and have to do it manually.

There is a task to add the workflows: https://issues.redhat.com/browse/OSASINFRA-2078

tnozicka
tnozicka approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@Fedosin
Copy link
Contributor Author

Fedosin commented Sep 22, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2020
@sttts
Copy link
Contributor

sttts commented Sep 23, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@adduarte
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adduarte, Fedosin, iamemilio, sttts, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d567919 into openshift:master Sep 23, 2020
@openshift-ci-robot
Copy link
Contributor

@Fedosin: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kubernetes-master-presubmits.yaml using file ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-kubernetes-master-presubmits.yaml using file ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

Assignees

@marun marun

@iamemilio iamemilio

@tnozicka tnozicka

@adduarte adduarte

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone