Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ocm-o to use golang 1.14 #11860

Merged

Conversation

adambkaplan
Copy link
Contributor

Upgrade cluster-openshift-controller-manager-operator to use golang 1.14.
Related to openshift/cluster-openshift-controller-manager-operator#175

Upgrade cluster-openshift-controller-manager-operator to use golang 1.14.
Related to openshift/cluster-openshift-controller-manager-operator#175
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2020
@adambkaplan
Copy link
Contributor Author

/assign @otaviof

We should make sure the dry run jobs complete before merging.

@openshift-ci-robot
Copy link
Contributor

@adambkaplan: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/cluster-openshift-controller-manager-operator/release-4.7/e2e-aws-upgrade aed3830 link /test pj-rehearse
ci/rehearse/openshift/cluster-openshift-controller-manager-operator/release-4.6/e2e-aws aed3830 link /test pj-rehearse
ci/rehearse/openshift/cluster-openshift-controller-manager-operator/master/e2e-aws aed3830 link /test pj-rehearse
ci/rehearse/openshift/cluster-openshift-controller-manager-operator/release-4.7/e2e-aws-operator aed3830 link /test pj-rehearse
ci/rehearse/openshift/cluster-openshift-controller-manager-operator/release-4.7/e2e-aws aed3830 link /test pj-rehearse
ci/prow/pj-rehearse aed3830 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Member

soltysh commented Sep 16, 2020

Also you should think of upgrading to golang 1.15

@openshift-merge-robot openshift-merge-robot merged commit 8ada700 into openshift:master Sep 16, 2020
@openshift-ci-robot
Copy link
Contributor

@adambkaplan: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-openshift-controller-manager-operator-master.yaml using file ci-operator/config/openshift/cluster-openshift-controller-manager-operator/openshift-cluster-openshift-controller-manager-operator-master.yaml
  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-openshift-controller-manager-operator-release-4.6.yaml using file ci-operator/config/openshift/cluster-openshift-controller-manager-operator/openshift-cluster-openshift-controller-manager-operator-release-4.6.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-openshift-controller-manager-operator-release-4.7.yaml using file ci-operator/config/openshift/cluster-openshift-controller-manager-operator/openshift-cluster-openshift-controller-manager-operator-release-4.7.yaml

In response to this:

Upgrade cluster-openshift-controller-manager-operator to use golang 1.14.
Related to openshift/cluster-openshift-controller-manager-operator#175

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
5 participants