Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry-Replacer autoupdate #12033

Merged
merged 1 commit into from Sep 19, 2020
Merged

Registry-Replacer autoupdate #12033

merged 1 commit into from Sep 19, 2020

Conversation

openshift-bot
Copy link
Contributor

This PR:

  • Adds a replacement of all FROM registry.svc.ci.openshift.org/anything directives found in any Dockerfile
    to make sure all images are pulled from the build cluster registry
  • Prunes existing replacements that do not match any FROM dircetive in the Dockerfile
  • Ensures the Dockerfiles used for promotion jobs matches the ones configured in ocp-build-data

@openshift-bot openshift-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Sep 19, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5617cd1 into openshift:master Sep 19, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Updated the following 3 configmaps:

  • ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-priv-bond-cni-release-4.6.yaml using file ci-operator/config/openshift-priv/bond-cni/openshift-priv-bond-cni-release-4.6.yaml
    • key openshift-priv-cluster-api-provider-ovirt-release-4.6.yaml using file ci-operator/config/openshift-priv/cluster-api-provider-ovirt/openshift-priv-cluster-api-provider-ovirt-release-4.6.yaml
    • key openshift-priv-loki-release-4.6.yaml using file ci-operator/config/openshift-priv/loki/openshift-priv-loki-release-4.6.yaml
    • key openshift-priv-node-feature-discovery-release-4.6.yaml using file ci-operator/config/openshift-priv/node-feature-discovery/openshift-priv-node-feature-discovery-release-4.6.yaml
    • key openshift-bond-cni-release-4.6.yaml using file ci-operator/config/openshift/bond-cni/openshift-bond-cni-release-4.6.yaml
    • key openshift-cluster-api-provider-ovirt-release-4.6.yaml using file ci-operator/config/openshift/cluster-api-provider-ovirt/openshift-cluster-api-provider-ovirt-release-4.6.yaml
    • key openshift-loki-release-4.6.yaml using file ci-operator/config/openshift/loki/openshift-loki-release-4.6.yaml
    • key openshift-node-feature-discovery-release-4.6.yaml using file ci-operator/config/openshift/node-feature-discovery/openshift-node-feature-discovery-release-4.6.yaml
    • key openshift-node-problem-detector-release-4.6.yaml using file ci-operator/config/openshift/node-problem-detector/openshift-node-problem-detector-release-4.6.yaml
    • key openshift-ovirt-csi-driver-operator-release-4.6.yaml using file ci-operator/config/openshift/ovirt-csi-driver-operator/openshift-ovirt-csi-driver-operator-release-4.6.yaml
  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-priv-bond-cni-release-4.7.yaml using file ci-operator/config/openshift-priv/bond-cni/openshift-priv-bond-cni-release-4.7.yaml
    • key openshift-priv-cluster-api-provider-ovirt-release-4.7.yaml using file ci-operator/config/openshift-priv/cluster-api-provider-ovirt/openshift-priv-cluster-api-provider-ovirt-release-4.7.yaml
    • key openshift-priv-node-feature-discovery-release-4.7.yaml using file ci-operator/config/openshift-priv/node-feature-discovery/openshift-priv-node-feature-discovery-release-4.7.yaml
    • key openshift-priv-node-problem-detector-operator-release-4.7.yaml using file ci-operator/config/openshift-priv/node-problem-detector-operator/openshift-priv-node-problem-detector-operator-release-4.7.yaml
    • key openshift-priv-node-problem-detector-release-4.7.yaml using file ci-operator/config/openshift-priv/node-problem-detector/openshift-priv-node-problem-detector-release-4.7.yaml
    • key openshift-priv-ovirt-csi-driver-operator-release-4.7.yaml using file ci-operator/config/openshift-priv/ovirt-csi-driver-operator/openshift-priv-ovirt-csi-driver-operator-release-4.7.yaml
    • key openshift-bond-cni-release-4.7.yaml using file ci-operator/config/openshift/bond-cni/openshift-bond-cni-release-4.7.yaml
    • key openshift-cluster-api-provider-ovirt-release-4.7.yaml using file ci-operator/config/openshift/cluster-api-provider-ovirt/openshift-cluster-api-provider-ovirt-release-4.7.yaml
    • key openshift-loki-release-4.7.yaml using file ci-operator/config/openshift/loki/openshift-loki-release-4.7.yaml
    • key openshift-node-feature-discovery-release-4.7.yaml using file ci-operator/config/openshift/node-feature-discovery/openshift-node-feature-discovery-release-4.7.yaml
    • key openshift-node-problem-detector-release-4.7.yaml using file ci-operator/config/openshift/node-problem-detector/openshift-node-problem-detector-release-4.7.yaml
    • key openshift-ovirt-csi-driver-operator-release-4.7.yaml using file ci-operator/config/openshift/ovirt-csi-driver-operator/openshift-ovirt-csi-driver-operator-release-4.7.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-priv-csi-external-provisioner-master.yaml using file ci-operator/config/openshift-priv/csi-external-provisioner/openshift-priv-csi-external-provisioner-master.yaml
    • key openshift-priv-csi-external-resizer-master.yaml using file ci-operator/config/openshift-priv/csi-external-resizer/openshift-priv-csi-external-resizer-master.yaml
    • key openshift-priv-csi-livenessprobe-master.yaml using file ci-operator/config/openshift-priv/csi-livenessprobe/openshift-priv-csi-livenessprobe-master.yaml
    • key openshift-priv-node-feature-discovery-master.yaml using file ci-operator/config/openshift-priv/node-feature-discovery/openshift-priv-node-feature-discovery-master.yaml
    • key openshift-priv-ovirt-csi-driver-master.yaml using file ci-operator/config/openshift-priv/ovirt-csi-driver/openshift-priv-ovirt-csi-driver-master.yaml
    • key openshift-aws-pod-identity-webhook-master.yaml using file ci-operator/config/openshift/aws-pod-identity-webhook/openshift-aws-pod-identity-webhook-master.yaml
    • key openshift-configmap-reload-master.yaml using file ci-operator/config/openshift/configmap-reload/openshift-configmap-reload-master.yaml
    • key openshift-csi-external-attacher-master.yaml using file ci-operator/config/openshift/csi-external-attacher/openshift-csi-external-attacher-master.yaml
    • key openshift-csi-external-provisioner-master.yaml using file ci-operator/config/openshift/csi-external-provisioner/openshift-csi-external-provisioner-master.yaml
    • key openshift-csi-external-resizer-master.yaml using file ci-operator/config/openshift/csi-external-resizer/openshift-csi-external-resizer-master.yaml
    • key openshift-csi-livenessprobe-master.yaml using file ci-operator/config/openshift/csi-livenessprobe/openshift-csi-livenessprobe-master.yaml
    • key openshift-csi-node-driver-registrar-master.yaml using file ci-operator/config/openshift/csi-node-driver-registrar/openshift-csi-node-driver-registrar-master.yaml
    • key openshift-ib-sriov-cni-master.yaml using file ci-operator/config/openshift/ib-sriov-cni/openshift-ib-sriov-cni-master.yaml
    • key openshift-insights-operator-master.yaml using file ci-operator/config/openshift/insights-operator/openshift-insights-operator-master.yaml
    • key openshift-multus-admission-controller-master.yaml using file ci-operator/config/openshift/multus-admission-controller/openshift-multus-admission-controller-master.yaml
    • key openshift-must-gather-master.yaml using file ci-operator/config/openshift/must-gather/openshift-must-gather-master.yaml
    • key openshift-ocp-release-operator-sdk-master.yaml using file ci-operator/config/openshift/ocp-release-operator-sdk/openshift-ocp-release-operator-sdk-master.yaml
    • key openshift-route-override-cni-master.yaml using file ci-operator/config/openshift/route-override-cni/openshift-route-override-cni-master.yaml
    • key openshift-sdn-master.yaml using file ci-operator/config/openshift/sdn/openshift-sdn-master.yaml
    • key openshift-sriov-cni-master.yaml using file ci-operator/config/openshift/sriov-cni/openshift-sriov-cni-master.yaml
    • key openshift-thanos-master.yaml using file ci-operator/config/openshift/thanos/openshift-thanos-master.yaml
    • key operator-framework-operator-registry-master.yaml using file ci-operator/config/operator-framework/operator-registry/operator-framework-operator-registry-master.yaml

In response to this:

This PR:

  • Adds a replacement of all FROM registry.svc.ci.openshift.org/anything directives found in any Dockerfile
    to make sure all images are pulled from the build cluster registry
  • Prunes existing replacements that do not match any FROM dircetive in the Dockerfile
  • Ensures the Dockerfiles used for promotion jobs matches the ones configured in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelsmith joelsmith Awaiting requested review from joelsmith

@theishshah theishshah Awaiting requested review from theishshah

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
3 participants
@openshift-bot @openshift-ci-robot @openshift-merge-robot