Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup aws and azure upgrade jobs for o/k #12618

Merged
merged 3 commits into from Oct 14, 2020
Merged

Setup aws and azure upgrade jobs for o/k #12618

merged 3 commits into from Oct 14, 2020

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Oct 9, 2020

/cc @marun

@tnozicka tnozicka mentioned this pull request Oct 9, 2020
Merged
12 tasks
@tnozicka tnozicka force-pushed the kube-jobs branch 5 times, most recently from fb25044 to e42ab5e Compare October 9, 2020 15:56
marun
marun reviewed Oct 9, 2020
View reviewed changes
Copy link
Contributor

@marun marun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! It's a definite win to be able to block rebase PRs with on-demand upgrade jobs for aws azure and self-upgrade vs relying on voluntary cluster-bot invocations.

I sure wish we had working rehearsal for o/k so the self-upgrade workflow could be validated pre-merge. :/

ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yaml Show resolved Hide resolved
...or/step-registry/openshift/selfupgrade/aws/loki/openshift-selfupgrade-aws-loki-workflow.yaml Outdated Show resolved Hide resolved
ci-operator/step-registry/openshift/selfupgrade/aws/loki/OWNERS Outdated Show resolved Hide resolved
@tnozicka tnozicka changed the title Setup aws and azure upgrade jobs for o/k [WIP] Setup aws and azure upgrade jobs for o/k Oct 9, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 9, 2020
@vrutkovs
Copy link
Member

vrutkovs commented Oct 9, 2020

See also #12204 which adds azure workflow.

Self-upgrade workflow is not necessary - existing workflows can handle that too (CI would set release:initial and release:latest correctly for PRs)

@tnozicka tnozicka force-pushed the kube-jobs branch 3 times, most recently from bf9f028 to 0026277 Compare October 12, 2020 12:34
@openshift-ci-robot openshift-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 12, 2020
openshift-ci-robot
openshift-ci-robot reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tnozicka: 3 invalid OWNERS files

In response to this:

/cc @marun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ci-operator/step-registry/openshift/selfupgrade/OWNERS Outdated Show resolved Hide resolved
ci-operator/step-registry/openshift/selfupgrade/aws/OWNERS Outdated Show resolved Hide resolved
ci-operator/step-registry/openshift/selfupgrade/aws/loki/OWNERS Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 12, 2020
@tnozicka
Copy link
Contributor Author

dropped azure upgrade flow in favor of #12204

@tnozicka tnozicka force-pushed the kube-jobs branch 3 times, most recently from 9fc6cdf to 8e500b5 Compare October 12, 2020 15:15
@tnozicka
Copy link
Contributor Author

/retest

@tnozicka tnozicka changed the title [WIP] Setup aws and azure upgrade jobs for o/k Setup aws and azure upgrade jobs for o/k Oct 13, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2020
soltysh
soltysh approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2020
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Oct 14, 2020
@tnozicka tnozicka force-pushed the kube-jobs branch 3 times, most recently from 093453e to d1d833f Compare October 14, 2020 07:31
@vrutkovs
Copy link
Member

LGTM from upgrade workflow side

@openshift-ci-robot
Copy link
Contributor

@tnozicka: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/kubernetes/master/e2e-azure-upgrade 09ab571 link /test pj-rehearse
ci/prow/pj-rehearse 09ab571 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

soltysh
soltysh approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 522a79b into openshift:master Oct 14, 2020
@openshift-ci-robot
Copy link
Contributor

@tnozicka: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kubernetes-master.yaml using file ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-kubernetes-master-presubmits.yaml using file ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kubernetes-master-presubmits.yaml using file ci-operator/jobs/openshift/kubernetes/openshift-kubernetes-master-presubmits.yaml

In response to this:

/cc @marun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka tnozicka deleted the kube-jobs branch October 14, 2020 10:55
@petr-muller petr-muller mentioned this pull request Oct 21, 2020
Closed
@wking wking mentioned this pull request Aug 22, 2022
Merged
wking added a commit to wking/openshift-release that referenced this pull request Aug 23, 2022
@wking
ci-operator/config/openshift/cluster-version-operator: Fix B->A rollb…
7da7d9a 
…ack config

My initial approach from acd81b7
(ci-operator/config/openshift/cluster-version-operator: Separate A->B
and B->A jobs (openshift#31518), 2022-08-22) doesn't seem to have worked.
Follow up by pattern-matching from ebbee6d (Add AWS and Azure
upgrade jobs and AWS selfupgrade for o/k, 2020-10-09, openshift#12618) from
openshift/kubernetes, which was renamed to e2e-{platform}-downgrade in
6841f1c (All 4.7+ yearly should be given an interval, 2021-03-24,
openshift#17131), but is otherwise unchanged.
openshift-merge-robot pushed a commit that referenced this pull request Aug 23, 2022
@wking
ci-operator/config/openshift/cluster-version-operator: Fix B->A rollb…
85e2f72 
…ack config (#31580)

My initial approach from acd81b7
(ci-operator/config/openshift/cluster-version-operator: Separate A->B
and B->A jobs (#31518), 2022-08-22) doesn't seem to have worked.
Follow up by pattern-matching from ebbee6d (Add AWS and Azure
upgrade jobs and AWS selfupgrade for o/k, 2020-10-09, #12618) from
openshift/kubernetes, which was renamed to e2e-{platform}-downgrade in
6841f1c (All 4.7+ yearly should be given an interval, 2021-03-24,
#17131), but is otherwise unchanged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs left review comments

@marun marun marun left review comments

@openshift-ci-robot openshift-ci-robot openshift-ci-robot left review comments

@soltysh soltysh soltysh approved these changes

Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
7 participants
@tnozicka @vrutkovs @openshift-ci-robot @openshift-bot @marun @soltysh @openshift-merge-robot