Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/jobs/openshift/release: Drop --rehearsal-limit #12966

Merged
merged 1 commit into from
Oct 21, 2020
Merged

ci-operator/jobs/openshift/release: Drop --rehearsal-limit #12966

merged 1 commit into from
Oct 21, 2020

Conversation

wking
Copy link
Member

@wking wking commented Oct 20, 2020

Folks have been tuning this since b0d60e3 (#4789), most recently in 3f0040e (#6999). But with openshift/ci-tools#1315, we no longer need to fuss with this setting in order to see rehearsals for changes that touch lots of jobs, so let it fall back to pj-rehearse's default of 15.

@wking
ci-operator/jobs/openshift/release: Drop --rehearsal-limit
0d797c4 
Folks have been tuning this since b0d60e3 (Bump the limit of
rehearsed jobs, 2019-08-19, openshift#4789), most recently in 3f0040e (Raise
rehearsal-limit to 45 temporarily, 2020-02-03, openshift#6999).  But with [1],
we no longer need to fuss with this setting in order to see rehearsals
for changes that touch lots of jobs, so let it fall back to
pj-rehearse's default of 15.

[1]: openshift/ci-tools#1315
@wking
Copy link
Member Author

wking commented Oct 20, 2020

pj-rehearse:

There are no nodes that your pod can schedule to...

@wking
Copy link
Member Author

wking commented Oct 20, 2020

Seems like a temporary issue which has since cleared up.

/retest

@wking
Copy link
Member Author

wking commented Oct 20, 2020

All green :)

/assign @stevekuznetsov

@wking wking mentioned this pull request Oct 21, 2020
Closed
@stevekuznetsov
Copy link
Contributor

/lgtm
/hold

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@wking
Copy link
Member Author

wking commented Oct 21, 2020

We're waiting on openshift/ci-tools#1317

@wking
Copy link
Member Author

wking commented Oct 21, 2020

landed and published.

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 21, 2020
@openshift-merge-robot openshift-merge-robot merged commit 033f7c6 into openshift:master Oct 21, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: Updated the following 2 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-presubmits.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-presubmits.yaml
  • job-config-master configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-master-presubmits.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-presubmits.yaml

In response to this:

Folks have been tuning this since b0d60e3 (#4789), most recently in 3f0040e (#6999). But with openshift/ci-tools#1315, we no longer need to fuss with this setting in order to see rehearsals for changes that touch lots of jobs, so let it fall back to pj-rehearse's default of 15.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-rehearsal-limit-override branch October 21, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droslean droslean Awaiting requested review from droslean

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
4 participants
@wking @stevekuznetsov @openshift-ci-robot @openshift-merge-robot